Make the Baseline JIT depend on the Baseline Interpreter
Categories
(Core :: JavaScript Engine: JIT, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(5 files)
It should be impossible to enable the Baseline JIT without the interpreter, similar to how Ion requires Baseline. Then we can simplify a number of things (bug 1566330, bug 1552154, some other things).
We can probably land this at the end of this week or so, when an emergency back out will become increasingly unlikely.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D38276
|
|
Assignee | |
Comment 3•5 years ago
|
||
This is more symmetrical with baselineInterpreterWarmUpThreshold and the
baselineInterpreter/baselineJit options.
Depends on D38277
|
|
Assignee | |
Comment 4•5 years ago
|
||
This unblocks clean up of Ion bailouts and Baseline because we can now assume
the interpreter is enabled.
Depends on D38278
|
|
Assignee | |
Comment 5•5 years ago
|
||
If the script already has a BaselineScript or the Interpreter/JIT thresholds are the same,
we will immediately switch to Baseline JIT code at the same LOOPENTRY op. This should be
unlikely for most loops and the extra overhead for this case is negligible.
Depends on D38279
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/87958a037098
https://hg.mozilla.org/mozilla-central/rev/699a49dc1d50
https://hg.mozilla.org/mozilla-central/rev/b3c6bd8fc4cd
https://hg.mozilla.org/mozilla-central/rev/56b33927fd49
https://hg.mozilla.org/mozilla-central/rev/db5038b9b3d3
Description
•