Create an initial 'metrics.yaml' file for Gecko telemetry
Categories
(Data Platform and Tools :: Glean: SDK, task, P1)
Tracking
(Not tracked)
People
(Reporter: Dexter, Assigned: Dexter)
References
(Blocks 1 open bug)
Details
(Whiteboard: [telemetry:glean-rs:m7])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This bug is for introducing a metrics.yaml file in mozilla-central, which would hold the Glean SDK metric definition for the metrics marked as 'geckoview_streaming' in the histogram.json file.
The file should probably live in toolkit/components/telemetry/geckoview/streaming along with the GeckoView streaming telemetry implementation.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
We'd like to suggest the metrics.yaml
to live in the toolkit/components/telemetry module, in the toolkit/components/telemetry/geckoview/streaming
path. That's the same module where the Histograms.json
file lives. I have no strong opinion about this, but I was considering these factors:
- the Telemetry module build system will need to check, at build time, both the Histogram.json and the metrics.yaml;
- Gecko can be built without the Telemetry module and metrics.yaml doesn't make sense without its only consumer (the toolkit:telemetry module);
I saw you suggested for it to live in mozilla-central/mobile/android/geckoview/metrics.yaml
: would you be ok with it living in the telemetry module for the above reasons?
I don't feel strongly about this, but it might be less surprising for engineers.
Comment 2•5 years ago
|
||
(In reply to Alessio Placitelli [:Dexter] from comment #1)
We'd like to suggest the
metrics.yaml
to live in the toolkit/components/telemetry module, in thetoolkit/components/telemetry/geckoview/streaming
path. That's the same module where theHistograms.json
file lives. I have no strong opinion about this, but I was considering these factors:
- the Telemetry module build system will need to check, at build time, both the Histogram.json and the metrics.yaml;
- Gecko can be built without the Telemetry module and metrics.yaml doesn't make sense without its only consumer (the toolkit:telemetry module);
I saw you suggested for it to live in
mozilla-central/mobile/android/geckoview/metrics.yaml
: would you be ok with it living in the telemetry module for the above reasons?
I would be fine with this (and saw it in the proposal, and was fine with it). We already have mobile/android/base
reach out to toolkit/crash_reporter
(see https://searchfox.org/mozilla-central/rev/da855d65d1fbdd714190cab2c46130f7422f3699/mobile/android/base/moz.build#135-138).
I don't feel strongly about this, but it might be less surprising for engineers.
I also don't feel strongly about this, and trust you to know what folks working in toolkit/components/telemetry
will find natural.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
This registry file will be used for the new streaming
telemetry API used by GeckoView.
Comment 5•5 years ago
|
||
bugherder |
Description
•