[Tracking Requested - why for this release]:

Central as Beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=532c699da1ae426784b593e5b4681fbeaaf55594&selectedJob=256717148

Failure log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=256717148&repo=try&lineNumber=14282

:bwc , this seems to be caused by https://hg.mozilla.org/integration/autoland/rev/3c6a1d3f9168.
Can you please take a look?

task 2019-07-16T12:24:17.758Z] 12:24:17 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/signaling/src/peerconnection'
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - /builds/worker/workspace/build/src/sccache/sccache /builds/worker/workspace/build/src/clang/bin/clang++ -m32 -o Unified_cpp_src_peerconnection0.o -c -I/builds/worker/workspace/build/src/obj-firefox/dist/stl_wrappers -I/builds/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /builds/worker/workspace/build/src/config/gcc_hidden.h -DDEBUG=1 -DHAVE_UINT64_T -DWEBRTC_POSIX -DWEBRTC_BUILD_LIBEVENT -DWEBRTC_LINUX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/peerconnection -I/builds/worker/workspace/build/src/obj-firefox/media/webrtc/signaling/src/peerconnection -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/media -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/media/mtransport -I/builds/worker/workspace/build/src/media/webrtc -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/common -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/common/browser_logging -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/common/time_profiling -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/media-conduit -I/builds/worker/workspace/build/src/media/webrtc/signaling/src/mediapipeline -I/builds/worker/workspace/build/src/media/webrtc/trunk -I/builds/worker/workspace/build/src/media/webrtc/trunk/webrtc -I/builds/worker/workspace/build/src/netwerk/srtp/src/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -march=pentium-m -msse -msse2 -mfpmath=sse -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -Os -fno-omit-frame-pointer -funwind-tables -Werror -Wno-error=shadow -MD -MP -MF .deps/Unified_cpp_src_peerconnection0.o.pp /builds/worker/workspace/build/src/obj-firefox/media/webrtc/signaling/src/peerconnection/Unified_cpp_src_peerconnection0.cpp
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/media/webrtc/signaling/src/peerconnection/Unified_cpp_src_peerconnection0.cpp:29:
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - In file included from /builds/worker/workspace/build/src/media/webrtc/signaling/src/peerconnection/PacketDumper.cpp:6:
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - In file included from /builds/worker/workspace/build/src/media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.h:17:
[task 2019-07-16T12:24:17.759Z] 12:24:17 ERROR - /builds/worker/workspace/build/src/obj-firefox/dist/include/IPeerConnection.h:100:20: error: expected identifier
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - kInternalError = 9U,
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - ^
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - 1 error generated.
[task 2019-07-16T12:24:17.759Z] 12:24:17 INFO - /builds/worker/workspace/build/src/config/rules.mk:801: recipe for target 'Unified_cpp_src_peerconnection0.o' failed
[task 2019-07-16T12:24:17.759Z] 12:24:17 ERROR - make[4]: *** [Unified_cpp_src_peerconnection0.o] Error 1
[task 2019-07-16T12:24:17.760Z] 12:24:17 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/webrtc/signaling/src/peerconnection'
[task 2019-07-16T12:24:17.760Z] 12:24:17 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'media/webrtc/signaling/src/peerconnection/target' failed
[task 2019-07-16T12:24:17.760Z] 12:24:17 ERROR - make[3]: *** [media/webrtc/signaling/src/peerconnection/target] Error 2
[task 2019-07-16T12:24:17.760Z] 12:24:17 INFO - make[3]: *** Waiting for unfinished jobs....

That error looks like a #define conflict. I see a place in the tree where kInternalError is defined as a macro, but not on nightly:

https://searchfox.org/mozilla-central/source/dom/quota/QuotaCommon.h#93

There are lots of other places in the tree that use kInternalError as an identifier, so the quota code probably should use something else. Perhaps kQuotaInternalError.

:bwc , backing out 3c6a1d3f9168 solved the bustage

Let's not back out that bug. The fix is in quota manager anyhow.

(In reply to Byron Campen [:bwc] from comment #2)

That error looks like a #define conflict. I see a place in the tree where kInternalError is defined as a macro, but not on nightly:

https://searchfox.org/mozilla-central/source/dom/quota/QuotaCommon.h#93

There are lots of other places in the tree that use kInternalError as an identifier, so the quota code probably should use something else. Perhaps kQuotaInternalError.

I think that should work. Thanks for fixing this!

What's the appropriate try string for this change?

The patch works in the latest central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=1b15b0d037232edc6f87f7e5e5a837b3ee428696

(In reply to Byron Campen [:bwc] from comment #7)

What's the appropriate try string for this change?

The changing code is used for collecting failure cases of storage initialization. Unfortunately, we don't have a specific test for verified all the cases (because it's hard to let a normal operation (e.g. nsIFile::Remove()) fail without hacking the code). But, we do have some tests which run through some of the failure cases. For instance, [1] is one of an example.

So, I would suggest running all the mochitest, and xpcshell tests under "dom/quota/", "dom/indexedDB", "dom/cache" folders. (Sorry, I have been switching to try fuzzy for a long time, so I could give you the specific string for that)

[1] https://searchfox.org/mozilla-central/source/dom/quota/test/unit/test_unknownFiles.js#94

Check back on try.

Yeah, that try run went sideways somehow. Maybe due to bug 1541424. I think I'll need a particular ./mach try command.

./mach try -b do -p $platform dom/quota dom/indexedDB dom/cache

For the $platform I usually test Linux windows and osx.

Here is an example of testing window 64 and linux: "./mach try -b do -p linux,win64 dom/quota dom/indexedDB dom/cache"
https://treeherder.mozilla.org/#/jobs?repo=try&revision=13731aee7ab26ea074b559ee1d08d48361f972dd

Note: I tried "./mach try -b do -p all dom/quota dom/indexedDB dom/cache" this morning, but somehow it didn't work. It seems that you need to type the specific platforms.

Hi Byron, can your patch be landed on integration?

Importing it in the beta-sims solves the bustages:

Early: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=9bdb6707b69111f77ea9ad48f83f6f57d147b394

Late: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=7e23866b57e2eaf2131a9c6b71c6d2b4844096cc

Let's see if the try string from comment 13 works out.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=139ecc94594dd4b128a743365aa2780700acce4e

I guess try looks fine?

Yes, with comment 14 and 16, it should be ok.

https://hg.mozilla.org/mozilla-central/rev/998729df6030

Verified fixed with latest beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=003c357a66ccc63e1b70d5d6977d7c096280aeed