Picture-in-Picture window can spawn outside of displays view-area
Categories
(Toolkit :: Picture-in-Picture, defect, P3)
Tracking
()
People
(Reporter: github, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
Steps to reproduce:
Using the picture-in-picture mode on a video
Actual results:
PiP Window is created at the very bottom middle of the rectangle defined by the 4 outermost points of the total display area.
Thus, the window can be invisible, since it's out-of-bound of a multimonitor-setup that has a gap at the bottom (see attachment).
Expected results:
PiP-Window should be spawned in the visible display area.
Updated•5 years ago
|
While Playback is concerned with the video element, we don't do much work around window placement on screen. I think this would be better served by which ever component is responsible for positioning our windows -- though I'm not 100% on what that would be. Mike, you're familiar with PiP, would you be able to help me find a home for this?
Comment 2•5 years ago
|
||
Yep, I can move this to the right place, thanks.
Comment 3•5 years ago
|
||
Hi github,
In bug 1565117, I landed a patch in Firefox Nightly that should make Picture-in-Picture work better with multiple displays. Do you think you'd have time to see if it fixes your issue? You can get a copy of Firefox Nightly from here.
(In reply to Mike Conley (:mconley) (:⚙️) from comment #3)
Hi github,
In bug 1565117, I landed a patch in Firefox Nightly that should make Picture-in-Picture work better with multiple displays. Do you think you'd have time to see if it fixes your issue? You can get a copy of Firefox Nightly from here.
Hi Mike,
I'd love to but my PC died yesterday and I first need to get a new Storage controller.
I don't have any other machine with that setup, so I can't test it. Hopefully someone else might have a similar Displaysetup with Windows 7 in the meantime.
I might be able to check back before Sunday. If not, I can only reply from the 8th of August onward, since I'm travelling.
Comment 5•5 years ago
|
||
Thanks, github. I guess once you get your machine set up again, let us know whether or not it's still a problem with Nightly.
It's unclear if this is still a problem or not. I'm going to mark this a P3 to get it off the triage list for now, but I suspect this is a dupe of bug 1565117. I'll wait to hear back from github though.
Hello Mike,
As seen in the attached image, the Popup now spawns in the nearest visible display area, which still seems unsatisfactory.
I have launched the video on the middle display and I think that a Video Popup should always spawn on the display on which the window to that video currently is (in this case, the middle one, not the left display).
Regards,
Andreas
Updated•5 years ago
|
Updated•5 years ago
|
I've started using this feature quite a bit and I wish it would just open where the last PiP was closed, including the size. I have to move it every time to my preferred location.
Comment 8•4 years ago
|
||
bug 1578985 may fix this, or if not, make it easier to fix this.
Updated•3 years ago
|
Comment 9•3 years ago
|
||
In my case, the PiP window always spawns on the same screen where the browser window is on.
I believe there were new improvements on this since it was last tested.
Andreas, do you still have a system with a similar setup as originally reported? Can you test it again and have an opinion, please?
Thank you for your contribution!
Updated•3 years ago
|
Comment 10•3 years ago
|
||
I believe this issue no longer occurs, but if it were, it would have a higher severity.
P.S. Based on my testing of the PiP improvements in FX100, the PiP positioning appears to work correctly with multiple screens, however, I can't set up my systems like the reporter to test this edge case.
Comment 11•3 years ago
|
||
Hello everyone,
Github login is currently not working for me, that's why I'm on a different account.
I'm currently on Version 99.0b3 (64-Bit) and the behaviour is still the same as described in comment 6.
I have an update waiting, so I'll install that and then update this comment.
Comment 12•3 years ago
|
||
On Version 99.0b4 now. PopUp-Videos still spawn in the position as described in comment 6.
When I create a new profile, all the pop-up videos spawn in the lowest right corner on the right-most display.
I believe that the pop-up videos do not honor the window from which the video originates but rather where the first window has been created or something along those lines. Even when I move all windows to the left display, the pop-up window still spawn on the right-most display.
Comment 13•3 years ago
|
||
This is surprising, after bug 1578985 I'd expect PiP to remember the location of the popout. Are you not seeing that at all? That is, if you open PiP, move the PiP window itself somewhere, then close it, then reopen it, is it reopening in a different location? Or is this not persisted after a restart? Or...?
Comment 14•3 years ago
|
||
Oh I'm sorry. I wasn't aware that this was the preferred behaviour now.
If I move the PiP, close it, hard reload (Ctrl + F5) the tab and open PiP again, it's on the same spot where I closed it.
Since that happens as it should, I guess this issue can now be closed.
I would've preferred it if the PiP-Position would be unique to each display, but that would get tricky with moving PiP-windows between displays while the parent doesn't move.
Comment 15•3 years ago
|
||
The behavior that I mentioned in comment 10 is related to where the browser spawns a PiP window when it has never been used in the current user profile. In newly created profiles, the PiP window will open in the bottom-right corner of the screen where the browser is positioned. After that, it will spawn where it was last positioned, even after restarting the profile.
Considering the discussion above, I will close this ticket as worksforme. Please feel free to reopen it if the issue reproduces again.
Description
•