Update spec/core wasm tests
Categories
(Core :: JavaScript: WebAssembly, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: rhunt, Assigned: rhunt)
References
Details
Attachments
(3 files)
There are some test changes in the bulk-memory-operations repo that will need to be imported for bug 1559962. I think it'd be good to do another import of the canon spec while we're at it.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
My plan of attack is to first do an import using recent canon spec, followed by an import of a commit after merging the changes from bulk-memory-operations on the canon spec. The second import will be a part of bug 1559962 to fix errors introduced by the changes there.
The reason I'm trying a merge here is that there are some changes in upstream that aren't reflected in bulk-memory-operations, and I think it would be good to have both.
I've set up a branch on my clone of the spec repo to help track this. [1]
[1] https://github.com/eqrion/spec/tree/spidermonkey-tree-tests
Assignee | ||
Comment 3•5 years ago
|
||
Not doing this fails 'binary.wast:536' as we will report an OOM error instead
of a validation error.
Assignee | ||
Comment 4•5 years ago
|
||
Hmm. Looks like the patch update the tests is too large for phabricator. I'll see if I can split it, or figure something out.
Assignee | ||
Comment 5•5 years ago
|
||
This commit updates the spec/core wasm tests to WebAssembly/spec@666dc4cb8d4a81d386a7a716000bb85fbbbd06a2
I've created a branch 'spidermonkey-tree-tests' on https://github.com/eqrion/spec to track as well.
wasm-constants.js and wasm-module-builder.js were removed from the harness and don't appear to
be needed, so their references from wasm-testharness.js were removed.
There were five failing tests after the import.
- utf8-custom-section-id.wast
- names.wast
- linking.wast
- imports.wast
- exports.wast
These tests were failing before this import, and so they remain excluded.
Depends on D38651
Assignee | ||
Comment 6•5 years ago
|
||
This is the second part of the previous commit that contains the updated
tests for WPT.
Depends on D38656
Assignee | ||
Comment 8•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=66b5f58643ad2422d13a88aa356a6efbe82ca960
I had to drop two new tests that had some tricky to debug test failures. 'memory_trap.wast', which only failed on linux32 arm sim, and 'align.wast' which only failed on windows. I will file bugs as follow ups to figure out what's going on.
Comment 9•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ecd49b738218
https://hg.mozilla.org/mozilla-central/rev/aed9fbbcfecd
https://hg.mozilla.org/mozilla-central/rev/9017c6a8e75a
Assignee | ||
Comment 11•5 years ago
|
||
Looks like the test import is generating numeric separators in JS which is supported in nightly but not beta. Bug 1435818 tracks enabling numeric separators for release. I'll try and modify the build script to not generate these separators and do a re-import.
Description
•