Fix quality issues with picture caching when the transform has a fractional offset.
Categories
(Core :: Graphics: WebRender, defect, P3)
Tracking
()
People
(Reporter: gw, Assigned: gw)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
This patch reverts the previous attempted fix for snapping issues
with picture caching, and implements a better solution.
This fixes the main visual issue by ensuring that any fractional
offset in the root transform is accounted for by:
- Offsetting the tile rects by this amount, so that the content
origin is a whole device pixel. - Invalidating all tiles if the fractional part of the root
transform changes. This is required since it can affect the
snapping logic that WR applies. Fortunately, this occurs
very rarely - Gecko typically has a constant fractional part
for each page.
Assignee | ||
Comment 2•5 years ago
|
||
Pending try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c37fe6296ec248161e57710c4dffcac65451b5ff
Updated•5 years ago
|
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a2fdbfed0d71 Fix quality issues with picture caching when the transform has a fractional offset. r=kvark
Comment 4•5 years ago
|
||
bugherder |
Comment 5•5 years ago
|
||
Backed out changeset a2fdbfed0d71 for causing Bug 1567089.
Backout link: https://hg.mozilla.org/integration/autoland/rev/8442d36972721915a1d00d7c4f06f0a9872b0769
Failure logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257120387&repo=mozilla-central&lineNumber=4835
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=257119909&repo=autoland&lineNumber=25771
![]() |
||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
I'll investigate this today, and get it re-landed.
Even if I just comment out those debug asserts that are occurring on a couple of tests, this patch should still be a net improvement on what's currently in m-c. But I'll look into those test cases / platforms that hit the assert this morning, and see if I can work out what's going on first.
Assignee | ||
Comment 8•5 years ago
|
||
Rebased and updated patch to account for zoom factors in the root transform, which was causing a test failure on some platforms.
Pending try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=11dc6dfe8a21404ef2858974e2f01bccfc53fc86
Comment 10•5 years ago
|
||
Pushed by gwatson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5c6895ea59af Fix quality issues with picture caching when the transform has a fractional offset. r=kvark
Comment 11•5 years ago
|
||
bugherder |
Assignee | ||
Comment 12•5 years ago
|
||
Comment on attachment 9078586 [details]
Bug 1566712 - Fix quality issues with picture caching when the transform has a fractional offset.
Beta/Release Uplift Approval Request
- User impact if declined: Visual artifacts in text rendering on some platforms with WebRender on some pages.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This will fix some or all of these beta bugs for users with WR enabled:
https://bugzilla.mozilla.org/show_bug.cgi?id=1566178
https://bugzilla.mozilla.org/show_bug.cgi?id=1541072
https://bugzilla.mozilla.org/show_bug.cgi?id=1565473
https://bugzilla.mozilla.org/show_bug.cgi?id=1566517
- String changes made/needed:
Comment 13•5 years ago
|
||
Comment on attachment 9078586 [details]
Bug 1566712 - Fix quality issues with picture caching when the transform has a fractional offset.
Fixes a number of text rendering bugs for users with WebRender enabled. Approved for 69.0b7.
Description
•