Remove remaining external dependencies on Debugger
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
(Blocks 1 open bug)
Details
(Whiteboard: [debugger-mvp])
Attachments
(2 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1565621 factors out most debugger methods which are used in the rest of spidermonkey into a new DebugAPI class, but there are still some places where Debugger.h needs to be included by SpiderMonkey, so that code can access Debugger or associated internal structures like BreakpointSite.
The attached patch cuts the rest of these dependencies, so that Debugger.h is only included by Debugger-related files which are (or will be soon) in js/src/dbg. The main task is factoring out DebugScript (JSScript's associated debugging data) into its own (internal) files in js/src/dbg, and only interacting with it externally through DebugAPI. Some minor changes are also needed for places where Debugger objects are accessed directly.
|
||
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
Backed out changeset e412a79fe5f7 (bug 1566885) for build bustages in Debugger.cpp
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=258192677&resultStatus=superseded%2Ctestfailed%2Cbusted%2Cexception%2Crunnable&revision=e412a79fe5f76c27184979f3507d414dd051df2e
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=258192677&repo=mozilla-inbound&lineNumber=7001
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/c0c967cd341a58b4edb13a6dcefc5076cc92da00
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•5 years ago
|
Description
•