Closed
Bug 1566903
Opened 5 years ago
Closed 5 years ago
cmd+f should re-select the searchbar query
Categories
(DevTools :: Debugger, enhancement, P3)
DevTools
Debugger
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: jlast, Assigned: khmorehouse)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
I've noticed that in editors cmd+f will always re-focus and select the searchbar text. This is useful when you're jumping between search results and want to quickly make changes in the searchbar. It is also a common convention that we should maintain.
Reporter | ||
Updated•5 years ago
|
Keywords: good-first-bug
Assignee | ||
Comment 1•5 years ago
|
||
I'd like to take this one, Jason.
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → khmorehouse
Priority: -- → P3
Assignee | ||
Comment 3•5 years ago
|
||
Jason, I'd like to zero-in on an accurate STR for this bug. Is the following one correct?
Steps to Reproduce:
- Navigate to http://todomvc.com/examples/backbone/
- Open the debugger
- Click the file
todomvc.com/examples/backbone/js/collections/todos.js
under the Sources tab in the left sidebar - Hit Cmd + F (or Ctrl+F on Windows)
- Type "collection"
- Hit Cmd + F (or Ctrl+F on Windows).
Expected Result:
- The query "collection" in the search bar should now be highlighted.
Actual Result:
- The query "collection" in the search bar is not highlighted.
Flags: needinfo?(jlaster)
Assignee | ||
Comment 5•5 years ago
|
||
This patch ensures that any existing query text in the search bar is highlighted when the Cmd/Ctrl + F shortcut is used.
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/af933062446a
Work-in-Progress Patch - Ensure that Ctrl/Cmd + F shortcut always re-selects the search bar query. r=jlast
Comment 7•5 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•