User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36

Steps to reproduce:

-An element/table element with display:table property.

-Following outline css is added through javascript
outline = "1px solid red";
outline-offset = "0px";

Actual results:

Outline is not visible.
But it gets visible once we update some DOM element. (DOM refresh)

Expected results:

Outline should be visible.
And this issue is coming after the firefox update.

Mozregression points to bug 1527210. Brian or Hiro, can any of you take a look? Otherwise I can.

Interesting, the problem doesn't happen on WebRender.

Anyways, I will take a look into this.

Some of changes in https://hg.mozilla.org/mozilla-central/rev/5cf9e494f690 look overkill. Here and here and here. Probably I missed them during review.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdbc79ca287601ba31fb3a72fdcd79511bce8200

We have to use the primary frame only if we process transform-related change
hints.

Per IRC conversation (https://mozilla.logbot.info/layout/20190719#c16479060) I can probably take this.

This is IMO the right RestyleManager change for what bug 1527210 tried to fix.

We need to apply the animation hints to the primary frame, not the style frame.
The other non-RestyleManager bits of that bug still apply and look fine to me.

They're wrong. When a property that affects the parent frame changes, we get a
hint for both frames. This fixes this bug.

Depends on D38598

We get hints for both frames, so we tag both.

Depends on D38599

I'm going to land this given I'm moderately confident this is the right way to fix it and so I can get this off my patch stacks, but Brian wanted to take a look at it so if he had the time to do that it'd be amazing.

https://hg.mozilla.org/mozilla-central/rev/47ff979267be
https://hg.mozilla.org/mozilla-central/rev/bb43baa7d8c9
https://hg.mozilla.org/mozilla-central/rev/81ab59a7247c
https://hg.mozilla.org/mozilla-central/rev/2d5ac5ef8f33

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

I'm going to land this given I'm moderately confident this is the right way to fix it and so I can get this off my patch stacks, but Brian wanted to take a look at it so if he had the time to do that it'd be amazing.

Fair enough. Thanks for taking care of this.

I was hoping we could get slightly more thoroughgoing commit messages for one or two of the patches but on second look they're not so bad. (I spent quite a bit of time of code archaeology when I wrote the original patches so I want to make sure the next person who has to work out the interaction between tables + transforms + animations has as much help as they can get.)

Not a new issue, so I think this fix can just ride the trains. Let me know if you disagree :)

Thank you for solving the issue. But it will be available in firefox70 release; till then can you provide any alternate solution that i can add in our project.

Easiest fix is probably wrapping your table in a <div> or something of that sort, if you can do that. If you can't, setting outline-offset to -1px causes the outline to be inside of the table box and get properly repainted.

If none of those work I'm happy to try figure out something else, just let me know.

Thank you for reporting the issue :)