Closed Bug 1567120 Opened 5 years ago Closed 5 years ago

0.23% installer size (osx-shippable) regression on push 9fc6f2b939d4edc7d09f10e096d46fb4e01ce382 (Fri July 12 2019)

Categories

(Firefox :: Security, defect)

Desktop
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: marauder, Unassigned)

References

(Regression)

Details

(Keywords: regression)

We have detected a build metrics regression from push:

https://hg.mozilla.org/integration/autoland/pushloghtml?changeset=9fc6f2b939d4edc7d09f10e096d46fb4e01ce382

As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

0.23% installer size osx-shippable opt nightly 79,105,737.67 -> 79,285,961.17

You can find links to graphs and comparison views for each of the above tests at: https://treeherder.mozilla.org/perf.html#/alerts?id=21847

On the page above you can see an alert for each affected platform as well as a link to a graph showing the history of scores for this test. There is also a link to a treeherder page showing the jobs in a pushlog format.

To learn more about the regressing test(s), please see: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Automated_Performance_Testing_and_Sheriffing/Build_Metrics

*** Please let us know your plans within 3 business days, or the offending patch(es) will be backed out! ***

Component: General → Security
Flags: needinfo?(jhofmann)
Flags: needinfo?(carolina.jimenez.g)
OS: Unspecified → macOS
Product: Testing → Firefox
Hardware: Unspecified → Desktop
Version: Version 3 → unspecified
Flags: needinfo?(carolina.jimenez.g) → needinfo?(dkeeler)

This is expected. We added some new libraries to re-implement the certificate viewer. When we're ready to ship the new version, we can remove the old one, thus decreasing the installer size by a similar amount.

Flags: needinfo?(dkeeler)

Yeah, we've added a large third party library and this is the effect. As Dana says, in the mid term there will be benefits to this.

Marking this as WONTFIX for now to move it forward, though I'd still like to understand how problematic 0.23% installer size regression is. Is that a large number or a small number?

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jhofmann)
Resolution: --- → WONTFIX
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.