Closed
Bug 1567167
Opened 5 years ago
Closed 5 years ago
Remove webconsoleClient calls within JsTerm
Categories
(DevTools :: Console, task, P1)
DevTools
Console
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
Details
(Whiteboard: dt-fission)
Attachments
(4 files)
No description provided.
Assignee | ||
Updated•5 years ago
|
Whiteboard: dt-fission
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
The function is only called from the context-menu,
where we already have all the references we need.
So we can move the function code directly in the
menu item callback.
Depends on D38612
Assignee | ||
Comment 3•5 years ago
|
||
This shouldn't be JSTerm's responsability to call
this function. Furthermore, the function clear
some references in the WebConsoleFront, which are
going to be destroyed anyway.
Depends on D38613
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D38614
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/621f1f846464
Remove unused gSequenceId function in JSTerm . r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/d0c3b8c500e1
Remove copyObject function from JSTerm. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/5f481c196743
Remove clearNetworkRequests from JsTerm destroy function. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/bf0b7dffc7b4
Remove webConsoleClient getter from JSTerm. r=jdescottes.
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/621f1f846464
https://hg.mozilla.org/mozilla-central/rev/d0c3b8c500e1
https://hg.mozilla.org/mozilla-central/rev/5f481c196743
https://hg.mozilla.org/mozilla-central/rev/bf0b7dffc7b4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•