The direction of about:logins website address text is wrong
Categories
(Toolkit :: Password Manager, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | unaffected |
firefox70 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: jaws)
References
()
Details
(Keywords: regression, rtl, Whiteboard: [passwords:management])
Attachments
(2 files)
STR:
- Open about:logins and look at an entry with a website address that ends in a slash.
See the screenshot.
We should probably use dir=auto
here as well.
Comment 1•5 years ago
|
||
(In reply to :Ehsan Akhgari from comment #0)
STR:
- Open about:logins and look at an entry with a website address that ends in a slash.
Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?
See the screenshot.
The screenshot is missing.
Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?
Comment 2•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
(In reply to :Ehsan Akhgari from comment #0)
STR:
- Open about:logins and look at an entry with a website address that ends in a slash.
Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?
This is not really true, the origin string can easily end with a slash, for example for "file://" origins.
See the screenshot.
The screenshot is missing.
Sorry about that, attaching it now.
Is this a regression compared to the old management UI: chrome://passwordmgr/content/passwordManager.xul ?
Yes. Years ago I fixed this same bug in the old UI in bug 478430.
Comment 4•5 years ago
|
||
(In reply to :Ehsan Akhgari from comment #3)
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #1)
(In reply to :Ehsan Akhgari from comment #0)
STR:
- Open about:logins and look at an entry with a website address that ends in a slash.
Saved logins are origins, not URLs, so none should end in a slash unless you have bad data. Can you give more details?
This is not really true, the origin string can easily end with a slash, for example for "file://" origins.
Right, that is the only case I can think of and we already don't handle that properly in the list…
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Comment 7•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Description
•