Lists in contenteditable
Categories
(Core :: Layout: Generated Content, Lists, and Counters, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | wontfix |
| firefox68 | --- | wontfix |
| firefox69 | --- | fixed |
| firefox70 | --- | fixed |
People
(Reporter: versusvirus, Assigned: MatsPalmgren_bugz)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/gif
|
Details | |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
lists_ff.gif
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.100 Safari/537.36
Steps to reproduce:
1.Create contenteditable
2.Insert list inside
3.in css ul elements must have list-style-postion: inside
Actual results:
The marker is in the wrong position
Expected results:
Marker has correct position
|
Reporter | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
|
||
Rehression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5dc0652cd024fef30217ac3e6087b7a32f16967f&tochange=9bad25ccc8d0414e21d3c8d4dcf2178a97bb07c3
Regressed by: Bug 1518201, Bug 288704, Bug 205202
|
|
||
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
(I'll try to take a look since mats is on PTO, but leaving ni? in his queue too just in case I don't get to it)
|
Assignee | |
Comment 5•5 years ago
|
||
I'll take a look...
|
|
Assignee | |
Comment 7•5 years ago
|
||
|
|
Assignee | |
Comment 8•5 years ago
|
||
Pushed by mpalmgren@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/237b431a3ffc [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/18045 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged
|
||
Comment 13•5 years ago
|
||
| bugherder | ||
|
||
Comment 14•5 years ago
|
||
Please nominate this for Beta approval when you get a chance.
|
|
Assignee | |
Comment 15•5 years ago
|
||
Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio
Beta/Release Uplift Approval Request
- User impact if declined: wrong layout of list-item marker after dynamic DOM change
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Fairly straight-forward patch.
- String changes made/needed:
|
|
||
Comment 16•5 years ago
|
||
Comment on attachment 9079794 [details]
Bug 1567773 - [css-lists] Look for an inside ::marker frame too when searching for a suitable sibling. r=emilio
Fixes wrong layout of list-item marker after dynamic DOM changes and includes an automated test. Approved for 69.0b10.
|
|
||
Comment 17•5 years ago
|
||
| bugherder uplift | ||
|
||
Updated•2 years ago
|
Description
•