Closed Bug 1567841 Opened 5 years ago Closed 5 years ago

Keep a referenced of the current "focused" target in the console

Categories

(DevTools :: Framework, task, P3)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1588697

People

(Reporter: nchevobbe, Unassigned)

References

(Blocks 1 open bug)

Details

The focused target can be impacted by the following case:

  • the debugger is paused (can be in a worker, an oop-frame, main context frame)
  • the user "navigated" to a different frame using the cd command
  • the user "navigated" to a different frame using the frame picker (in Browser Toolbox)

To reflect what has been said during the last fission meeting.
I don't think this is a top priority for now.

Nonetheless, you are highlighting the fact that we have multiple, very different ways to target one specific context (which can be a worker, or a frame). Each case you mentioned is actually using an extremelly different codepath.

This was a description of the current codebase.
Now as to what we should be doing:

  • We should have a unified way of selecting a given target. The targets are: tab's documents, any of its iframes (remote or not), workers. But we have some others in the context of the browser toolbox: addons and processes.
  • This should be managed on the client side.
  • We may have more than one target actually selected at a time. We would most likely keep the "top level target", which may always be the top level tab's document target. And a "currently selected evaluation target", which would only impact JSTerm input and may be a bit of the debugger.

Here is a few outcomes of these two conclusions:

  • We should pull out some logic that is currently managed into the debugger redux store. This would naturally go into fronts rather than one tool internal data. We shouldn't need to start the debugger in order to start selecting another target.
  • We should convert the iframe picker and cd command to a client side logic.

This work will most likely depend on bug 1565263 for the frame picker.

Depends on: 1565263
Summary: Keep a referenced of the current "focused" target → Keep a referenced of the current "focused" target in the console

Putting as P3 since the interaction with the debugger already works.
We'll have to check for the cd command when we start working on it (but for now, cd only changes the evaluation context, which is handled on the webconsoleActor with the evalWindow getter)

Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Whiteboard: dt-fission-reserve
You need to log in before you can comment on or make changes to this bug.