Improve will-change budget access during display list building
Categories
(Core :: Web Painting, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: mikokm, Assigned: mikokm)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
The hashtable lookup for will-change budgeting was occasionally showing up in profiles, when investigating Youtube live chat performance (bug 1533815). We can avoid this by checking nsIFrame::MayHaveWillChangeBudget().
These patches showed a 1-2% improvement on DL mutate test on my MBP.
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D38851
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D38852
|
||
Comment 4•5 years ago
|
||
There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:miko, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 5•5 years ago
|
||
This patch is incomplete. When doing a full display list rebuild, we call nsDisplayListBuilder::ClearWillChangeBudget(), which does not clear the will-change flag from the frames. This can be solved by unconditionally clearing the flag, if we are doing a full display list build.
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7534c2a4a2d1
https://hg.mozilla.org/mozilla-central/rev/fe519c374527
https://hg.mozilla.org/mozilla-central/rev/8ebcde6a7778
Description
•