Popup blocker sub-item in the identity popup should be indented
Categories
(Firefox :: Site Identity, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox-esr68 | --- | fixed |
| firefox68 | --- | wontfix |
| firefox69 | --- | verified |
| firefox70 | --- | verified |
People
(Reporter: johannh, Assigned: johannh)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr68+
|
Details |
Screenshot 2019-07-22 at 14.56.08.png
It's supposed to look like below. This was caused by bug 1501991 adding 12px extra padding to the permission icons without considering the arrow.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
|
||
Looks like a pretty safe patch to uplift. Did you want to nominate it for Beta & ESR68 approval?
|
|
Assignee | |
Comment 5•5 years ago
|
||
Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz
Beta/Release Uplift Approval Request
- User impact if declined: Slight style regression in the identity popup that makes it less clear that the popup-subitem belongs to its parent.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: - Open a blocked popup
- Click on the identity block to open the identity panel
- The permissions section should look like it's shown in comment 0
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple front-end patch that mostly updates styles
- String changes made/needed: None
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
||
Comment 6•5 years ago
|
||
Confirmed issue with 69.0b8.
Fix verified with 70.0a1 (2019-07-28) .
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz
Simple UI clean-up. Approved for 69.0b9.
|
|
||
Comment 8•5 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 9•5 years ago
|
||
Fix verified with 69.09 on Windows 10, macOS 10.13, Ubuntu 16.04.
|
|
||
Comment 10•5 years ago
|
||
Hi Johann, did you want to nominate this for ESR68 approval too?
|
|
Assignee | |
Comment 11•5 years ago
|
||
Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Low risk patch that polishes permissions UI
- User impact if declined: Slight style regression in the identity popup that makes it less clear that the popup-subitem belongs to its parent.
- Fix Landed on Version: 69 & 70
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple front-end patch that mostly updates styles
- String or UUID changes made by this patch: None
|
|
||
Comment 12•5 years ago
|
||
Comment on attachment 9079906 [details]
Bug 1568108 - Indent popup sub-item in the identity popup. r=pbz
Minor UI fixup. Approved for 68.1esr.
|
||
Comment 13•5 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
Description
•