Closed Bug 1568353 Opened 5 years ago Closed 5 years ago

Some FxA related network requests never timeout

Categories

(Firefox :: Firefox Accounts, defect, P1)

68 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: wb0gaz, Assigned: markh)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Windows 7 32-bit , firefox 68.0.1 32-bit - machine frequently goes through suspend cycles with firefox running.

Workaround - exit then restart firefox (fixes this issue every time.)

This problem has existed for some months at least (noticed it first when I discovered that my intended data - bookmarks - was not propagating across machines all logged into the same firefox account.)

Actual results:

Firefox sometimes (frequently) ends up with "syncing.." continuously active, and no sync update is occurring.

Expected results:

"syncing..." software should detect that it is in this state with no productive data transfer, and restart the underlying activity.

Component: Untriaged → Sync

Thanks for reporting this and I'm sorry sync is misbehaving for you.

Are you sure this is related to sleep/suspend, or could it just happen at seemingly "random" times? Eg, we have bug 1483976 (which we don't really understand yet) and that doesn't seem to be related to sleep or suspend (although maybe it is) - the more details we can get, the better.

Something that would be very helpful is:

  • Install the about:sync addon from https://addons.mozilla.org/en-US/firefox/addon/about-sync/
  • When you next reproduce the problem, open about:sync, and in the "Log files and diagnostics" session, click the "Force a new (probably empty) log now".
  • Use about:sync to create a .zip file of all your sync logs, and email the .zip file to me via the address I use for bugzilla.

Thanks!

Flags: needinfo?(wb0gaz)

I got the logs and they demonstrate that some of the requests we make appear to block forever and never time out. This should be easy to fix - thanks!

Flags: needinfo?(wb0gaz)

rest.js already supports a timeout - it just defaults to not specifying one! It even has tests. The only consumers of rest.js left in the tree are FxAccounts related, so I think the right thing to do is just default all consumers of rest.js to a 5 minute timeout (the same Sync uses for its resources). I'll request review from :rfkelly as it's all FxA requests which are affected.

Component: Sync → Firefox Accounts
Summary: Firefox sync indicator "syncing..." continuously (after suspend) → Some FxA related network requests never timeout
Assignee: nobody → markh
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P1
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/85943ff078d9 set the default rest.js timeout to be 5 minutes. r=rfkelly
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: