Update the url crate to 2.0 in the webdriver crate
Categories
(Testing :: geckodriver, task, P2)
Tracking
(firefox70 fixed)
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: SimonSapin, Assigned: SimonSapin)
References
Details
Attachments
(3 files, 2 obsolete files)
This will help avoid having two versions of url
in Servo. To also avoid having two versions in mozilla-central, it also needs updating other crates:
Comment 1•5 years ago
|
||
We depend on tungstenite
through tokio
, so thanks for opening a PR there.
There doesn’t appear to be any API changes in url
that affects webdriver
moving from version 1 to 2.
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
I was planning to submit patches after all the other PRs have landed and are on crates.io, to avoid having a large revendor patch that duplicates multiple crates. But if you prefer landing this now, that works too.
Comment 5•5 years ago
|
||
We can hold off. It’s just running ./mach vendor rust
again.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
This is waiting on https://github.com/snapview/tungstenite-rs/issues/65, then a PR to https://github.com/seanmonstar/warp.
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
[import_pr] From https://github.com/servo/webrender/pull/3720
MozReview-Commit-ID: AsI4hT0cFGJ
Assignee | ||
Comment 9•5 years ago
|
||
Assignee | ||
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
Comment 12•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/74064a61eb29
https://hg.mozilla.org/mozilla-central/rev/8f9477c40136
https://hg.mozilla.org/mozilla-central/rev/4ddd4f285e36
Updated•5 years ago
|
Description
•