Closed
Bug 1568583
Opened 5 years ago
Closed 5 years ago
Convert geolocation from properties to keywords
Categories
(Firefox :: New Tab Page, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Iteration:
70.2 - Jul 22 - Aug 4
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: mmiermans, Assigned: ssami)
References
Details
Aderk doesn't support reporting based on custom properties, so we will switch to keywords.
- In adzerk/api.py, modify __add_targeting to set
keywords
instead ofproperties
. Countries should be prefixed bycountry-
and regions should be prefixed byregion-
. - Write a test in
tests/test_adzerk_api.py
to verify keywords are correctly passed to AdZerk. - Deploy the service to Pocket-Dev.
- Hit the /spocs endpoint on the staging server and verify the keywords show up in the
__debug__
object. - Create an ad in AdZerk and go through QA steps below.
QA:
- Target globally: ad should show up. (no keywords)
- Target the U.S.: ad should show up.
country-US
- Target California: ad should show up.
country-US,region-CA
- Target the west coast: ad should show up.
country-US,region-CA
country-US,region-OR
country-US,region-WA
- Target a different country: ad should not show up.
country-CA,region-CA
- Verify whether spaces after/before a comma matter: ad should show up.
country-US , region-CA
Reporter | ||
Updated•5 years ago
|
Points: 3 → 1
Assignee | ||
Comment 1•5 years ago
|
||
QA testing and table on interactions between keywords and site targeting is here: https://docs.google.com/document/d/1YHPr09aGir9cdLiTG1ugReEYTlVH7IG7zPfSQTIXA3U/edit#heading=h.x51rnaj5lg87
Assignee | ||
Updated•5 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•