Closed Bug 1568764 Opened 5 years ago Closed 4 years ago

Unskip and fix plugin tests for Fission now that the basic IPC infrastructure should be compatible

Categories

(Core Graveyard :: Plug-ins, task, P3)

Tracking

(Fission Milestone:M7, firefox70 affected)

RESOLVED WONTFIX
Fission Milestone M7
Tracking Status
firefox70 --- affected

People

(Reporter: Gijs, Unassigned)

References

Details

bug 1505913 switched to fission-compatible actors. In principle, that means all the tests should now pass. However, some tests may still need work done to the test when Fission is actually turned on, we left a few things (esp. related to fullscreen, which isn't yet Fission-compatible) and there are a few tests that are currently annotated as skip-if instead of fail-if for Fission which of course means we have to check "manually" if they pass now.

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?

Gijs, if this bug is just about unskipping plugin tests for Fission, is there a separate bug for actually fixing those test failures?

Fission Milestone: ? → M4.1
Flags: needinfo?(gijskruitbosch+bugs)

I think I filed this as a generic bug; I see from https://searchfox.org/mozilla-central/source/browser/base/content/test/plugins/browser.ini and browser/base/content/test/plugins/browser-rs-blocklist.ini that there are a handful of tests left. I think this bug could be used to fix any of the ones that we care about fixing and/or can enable now - or we could just wontfix this if we're confident we won't try to ship fission before we unship NPAPI plugins...

Flags: needinfo?(gijskruitbosch+bugs)

we could just wontfix this if we're confident we won't try to ship fission before we unship NPAPI plugins...

We hope to ship Fission before we unship NPAPI plugins, so we should try to fix these plugin tests.

I'll move this bug to a later Fission milestone (M6, enable Fission in Nightly) because Flash plugin support doesn't need to block internal dogfooding.

Fission Milestone: M4.1 → M6
Summary: Enable passing plugin tests for fission now that the basic IPC infrastructure should be compatible → Unskip and fix plugin tests for Fission now that the basic IPC infrastructure should be compatible

Fission will probably ship after we unship NPAPI plugins, so fixing and re-enabling these plugin tests doesn't need to block Fission Nightly. Let's still track this bug for Fission Beta (M7), just to make sure that schedule assumption is still true when Fission is ready to ride the trains.

Fission Milestone: M6 → M7
Priority: -- → P3

Plugins aren't going to work with Fission.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.