Make the inspector's search field work with remote targets
Categories
(DevTools :: Inspector, task, P3)
Tracking
(Fission Milestone:M7a, firefox90 fixed)
Tracking | Status | |
---|---|---|
firefox90 | --- | fixed |
People
(Reporter: pbro, Assigned: bomsy)
References
(Blocks 3 open bugs)
Details
(Whiteboard: dt-fission-m3-mvp)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
With Fission and when bug 1560200 is fixed, the markup-view will be displaying the DOM tree found in remote targets (oop iframes or remote browsers in the Browser Toolbox).
The search input field in the inspector will need to be adapted once that happens.
- It will need to be capable or returning auto-completion hints that also match nodes found in remote targets
- It will need to return all matching results once a search is submitted, even for notes found in remote targets
- It will need to be capable of selecting the resulting nodes in the markup-view.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Tracking Fission DevTools bugs for Fission Nightly (M6)
Comment 2•5 years ago
|
||
dt-fission-reserve bugs do not need to block Fission Nightly (M6).
Comment 3•4 years ago
|
||
Simple test case and STRs, so it's easy to reproduce:
STR:
- Load http://janodvarko.cz/tests/fission/case1/index.html
- Open DevTools Toolbox and select the Inspector panel
- Search for POST
- The POST in top level document is highlighted but the one in remote iframe is not -> BUG
Honza
Updated•4 years ago
|
Comment 4•4 years ago
|
||
Tracking dt-fission-m3-mvp bugs for Fission Beta milestone (M7).
Updated•4 years ago
|
Comment 5•4 years ago
|
||
Bulk move of all dt-fission-m3-mvp bugs to Fission MVP milestone.
Updated•4 years ago
|
Comment 7•4 years ago
|
||
Comment 3 is still valid.
The search feature is using the top-level target WalkerActor#search
method (devtools/server/actors/inspector/walker.js#1308-1319), which lives in the content process.
We'd need to go through all the different targets on the page to agglomerate the results on each of them before returning the results to the client.
For iterating over the different results, the inspector uses selection.setNodeFront
, which should work seamlessly.
Comment 8•4 years ago
|
||
Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).
Comment 9•4 years ago
|
||
Updated•4 years ago
|
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 10•4 years ago
|
||
Comment 11•4 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•