Use error code from about:certerror to create warning UI, explaining that there is an error with the certificate (expired, wrong host, self-signed, untrusted root, revoked, pinning test), and highlighting the associated info-item in the certificate-viewer.

Depends on D39530

Depends on D39531

Cosmin - it looks like this may not have been ready to land?

Hi Dana, I can back it out if you want. It had a dependency in phabricator on what Danielle marked as checkin-needed and it landed them all together.

Sorry for the confusion, let me try to figure out what happened here. I didn't mean for it to land them all together - my bad!

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=d0162a59fb9fef33d5472a6d0a3ce11a199caa4e&selectedJob=261381636

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261381636&repo=autoland&lineNumber=235

Backout link: https://hg.mozilla.org/integration/autoland/rev/b84520707dae09380c78d55999c050bf03486af4

[task 2019-08-13T18:00:25.853Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2019-08-13T18:00:25.853Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2019-08-13T18:00:25.853Z]
[task 2019-08-13T18:00:25.853Z] Error processing command. Ignoring because optional. (optional:packages.txt:comm/build/virtualenv_packages.txt)
[task 2019-08-13T18:14:53.103Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/base/content/browser.js:3650:13 | Delete ?? (prettier/prettier)
[task 2019-08-13T18:14:53.104Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/base/content/pageinfo/security.js:57:9 | 'isInsecure' is assigned a value but never used. (no-unused-vars)
[taskcluster 2019-08-13 18:14:53.606Z] === Task Finished ===
[taskcluster 2019-08-13 18:14:54.350Z] Unsuccessful task run with exit code: 1 completed in 1120.424 seconds

There are also these TV failures from the land: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261386808&repo=autoland&lineNumber=1971 this will probably turn into tier 1 failure.

Danielle, since there are multiple bugs tied together and need to be landed all at once could you please make sure you have the proper reviews for all of them before setting the checkin-needed keyword. Thank you.

Also please check these browser chrome failures: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261388390&repo=autoland&lineNumber=1916

Hey Danielle,

In browser/base/content/pageinfo/security.js you are returning error but the declaration of that variable is inside an if. Putting it outside the if statement and moving all the changes from browser/base/content/browser.js to browser/actors/NetErrorParent.jsm will solve most of the problems with this patch, in my opinion (See https://treeherder.mozilla.org/#/jobs?repo=try&revision=6454c602f92256ee992f1a4dd189cfa17dde9067). Also, lint is returning an error that require is not defined, I think that would be all needed to pass the tests.

Can we land this? I think it's a great patch to let it be forgotten.

Thank you.

Hey Carolina,

Sorry for the delay. I'll take a look at this now and get back to you asap. I've been having problems with this patch since I re-installed the mozilla-unified repo a couple months ago - does it allow you to rebase this patch onto central? I keep getting the error abort: source and destination form a cycle - it's driving me nuts!

Thanks!

I rebased it onto central with minimum merge conflicts, I thought it was going to be chaos since this wasn't updated for a while but surprisingly it wasn't! I have no clue on what is happening to you... Maybe running ./mach bootstrap again?

I think you can also download the revision and then import it directly onto central using ./hg import <file_name> if rebase doesn't work for you

Let me know!

Depends on D61226

The bug assignee didn't login in Bugzilla in the last 7 months.
:sgalich, could you have a look please?
For more information, please visit auto_nag documentation.