Closed Bug 1568985 Opened 5 years ago Closed 5 years ago

"Blackbox source" option doesn't toggle in source tree item menu

Categories

(DevTools :: Debugger, defect, P3)

70 Branch
defect

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: chujunlu, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36

Steps to reproduce:

  1. Open https://eminent-vault.glitch.me/
  2. Open debugger
  3. Open script.js file in editor panel
  4. Click blackbox button in footer
  5. Right click "script.js" in primary panel

Actual results:

In the menu, the second option is "Blackbox source". Click it and nothing happens.

Expected results:

The second option should be "Unblackbox source" since script.js is blackboxed. Clicking it will remove the blackbox icon in source tab.

Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P3

May I take this one?

Hey Kevin, I noticed this bug when I worked on a related bug. My proposed fix for the other one would fix this at the same time. I thought it's neater to have separated bugs documented so I filed this one. Would you mind wait a little bit? If my patch doesn't work, I'll update here.

Sorry if I create any confusion.

The abovementioned patch for another bug that might be able to fix this one: https://phabricator.services.mozilla.com/D39402

Okay, no problem! Maintainers: please disregard my earlier comment.

@digitarald I think this bug is fixed along with https://phabricator.services.mozilla.com/D39402.

Yes, works for me as well!

Sounds good! I should close this.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: