Closed
Bug 1569236
Opened 5 years ago
Closed 5 years ago
sqlList is unsafe
Categories
(Toolkit :: Places, defect, P2)
Toolkit
Places
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
our sqlList is unsafe, it just takes strings and puts them toghether in an IN clause. that is breaking badly if a url contains a quote.
Even if it's slower, we should bind.
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/f76f8522c4a3
bind history and bookmarks IN() clauses for safety reasons. r=Standard8
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•