Closed
Bug 1569341
Opened 5 years ago
Closed 5 years ago
Hide launch/copy buttons in edit mode
Categories
(Toolkit :: Password Manager, enhancement)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
(In reply to Matthew N. [:MattN] (PM me if requests are blocking you) from comment #2)
In the future you should include rationale in comment 0, filing bugs with no comment 0 is discouraged. I'm wondering what the rationale is… it seems like they could be useful if they used the live value in the fields instead of the value from storage. e.g. to test if the typed URL is correct.
This is just done to match the UX spec: https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931541
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f89ffd06d951
Hide launch/copy buttons in edit mode. r=MattN
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d80347b05879
Update test_login_item.html expectations to be correct. r=bustage-fix on a CLOSED TREE
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f89ffd06d951
https://hg.mozilla.org/mozilla-central/rev/d80347b05879
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
You need to log in
before you can comment on or make changes to this bug.
Description
•