Closed
Bug 1569495
Opened 5 years ago
Closed 5 years ago
Stop using inline styles and innerHTML in devtools ImageTooltipHelper
Categories
(DevTools :: about:debugging, task, P3)
DevTools
about:debugging
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: ckerschb, Assigned: jdescottes)
References
Details
Attachments
(2 files)
Within Bug 1567877 we are applying a meta CSP to about:devtools-toolbox. While that mostly works fine there is inline style code within ImageTooltipHelper.js [1] which needs to be refactored so we can remove the 'unsafe-inline' from the CSP. It's not a blocker for Bug 1567877 because we mostly want to avoid inline scripts. It would be good if we can get 'unsafe-inline' removed however.
Additionally that code uses innerHTML which we also want to avoid. So now there are already 2 reasons to refactor that piece of code :-)
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D39644
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/531fa7ad6b16
Stop using inline styles and inner HTML for image tooltip r=miker
https://hg.mozilla.org/integration/autoland/rev/6712b3dd77fc
Stop using innerHTML in HTML Tooltip r=miker
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Summary: Remove 'unsafe-inline' from the CSP of about:devtools-toolbox → Stop using inline styles and innerHTML in devtools ImageTooltipHelper
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P3
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/531fa7ad6b16
https://hg.mozilla.org/mozilla-central/rev/6712b3dd77fc
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•