Closed
Bug 1569781
Opened 5 years ago
Closed 5 years ago
Refreshing Netmonitor and clicking on a WS request shows Accordion
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: tanhengyeow, Assigned: tanhengyeow)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/75.0.3770.142 Safari/537.36
Steps to reproduce:
- Go to this test page and open Netmonitor.
- Make a WS connection, click on the WS request in Netmonitor, send a WS frame and click on the frame in the
Messages
panel. - The
Raw Data
Accordion is observed. - Refresh Netmonitor e.g. using Cmd + R.
- Make a new WS connection and click on the WS request in Netmonitor.
Actual results:
The Raw Data
Accordion is still observed.
Expected results:
Raw Data
Accordion should not be shown.
This is because when Netmonitor is refreshed, the WebSocketsPanel
is unmounted. At this point, if the Raw Data
Accordion is shown, it means that state.webSockets.frameDetailsOpen
is true.
There are two approaches we can take:
- Implement a
componentDidMount()
lifecycle to check for visible frame and callopenFrameDetailsTab(false)
if the visible frame is not found. - During the
componentWillUnmount()
lifecycle, callopenFrameDetailsTab(false)
to resetstate.webSockets.frameDetailsOpen
to false.
Approach 2 is cleaner as it does not require the isSelectedFrameVisible
selector call as compared to approach 1.
Assignee | ||
Updated•5 years ago
|
Blocks: network-websocket-inspector
Assignee | ||
Comment 1•5 years ago
|
||
Set frameDetailsOpen to false when WebSocketsPanel unmounts.
Updated•5 years ago
|
Assignee: nobody → E0032242
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6fe2e0df145
Refreshing Netmonitor and clicking on a WS request shows Accordion. r=nchevobbe
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Updated•5 years ago
|
QA Whiteboard: [qa-70b-p2]
You need to log in
before you can comment on or make changes to this bug.
Description
•