Closed
Bug 1570821
Opened 5 years ago
Closed 5 years ago
Limit height for variable tooltip to preserve space
Categories
(DevTools :: Debugger, enhancement, P5)
DevTools
Debugger
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: Harald, Assigned: shellyc23)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(3 files)
Firefox
What were you doing?
- Pause in an event listener
- Hover an element or
event.target
What happened?
Tooltip taking the full width of the Debugger, which in vertical mode is a lot.
What should have happened?
Limit it to a reasonable size and scroll the rest.
Anything else we should know?
Chrome limit size.
|
Reporter | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
Limiting the height sounds reasonable. To something like Chrome's or a bit taller maybe.
As mentioned on Slack the left padding seems a bit extra too.
|
|
Reporter | |
Updated•5 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 3•5 years ago
|
||
I would like to take a stab at this.
|
||
Comment 4•5 years ago
|
||
Sounds good Krishnal! Let me know if you need help!
|
|
Assignee | |
Comment 5•5 years ago
|
||
Added and if statement to calculateMaxHeight() to prevent it from exceeding 250, and decresed the padding of the .object-node selector.
Pushed by dwalsh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8dc5c551235
limit height for variable tooltip and decrease left padding r=davidwalsh
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
Assignee: nobody → shellyc23
You need to log in
before you can comment on or make changes to this bug.
Description
•