Remove JSScript::dataSize field
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: tcampbell, Assigned: whawkins)
References
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The JSScript::dataSize_ field provides little value and we should be able to remove it. Currently it computes the size of the PrivateScriptData / JSScript::data_ structure. With the current simplified format of PrivateScriptData, we can quickly compute the size on demand.
- Add a PrivateScriptData::allocationSize() public method (similar to LazyScriptData::allocationSize())
- Update the definition of JSScript::computedSizeOfData() to use this
- Remove JSScript::dataSize_ / dataSize()
|
Reporter | |
Updated•5 years ago
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9e3f6c988710
Calculate the data size of a JSScript dynamically. r=tcampbell
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
|
||
Comment 4•5 years ago
|
||
== Change summary for alert #22427 (as of Tue, 13 Aug 2019 06:27:55 GMT) ==
Improvements:
0.25% Base Content JS windows7-32-shippable opt 3,249,493.33 -> 3,241,301.33
0.25% Base Content JS windows7-32-shippable opt 3,249,509.33 -> 3,241,269.33
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22427
Description
•