Closed Bug 1572464 Opened 5 years ago Closed 5 years ago

The "No Logins" screen should be different if the users are logged into a FxA account

Categories

(Firefox :: about:logins, enhancement, P3)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: cmuntean, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [skyline] [strings])

Attachments

(2 files)

[Notes]:

  • Since the same text and information is displayed whether you are logged in or not, this might be confusing for the users after syncing if they don't have any logins saved and synced.
  • Also, the "Looking for your saved logins? Set up sync." message can be confusing if you are already logged and you don't have any logins saved.
  • From the QA point of view, if the user is already logged to a FxA account the screen should explain advantages of sync instead of how to set up the sync.

[Affected Versions]:

  • Nightly 70.0a1

[Affected Platforms]

  • All Windows
  • All Mac
  • All Linux

[Prerequisites]

  • Have a Firefox profile with no saved logins.
  • Be logged with a valid FxA account that doesn't have any logins synced.

[Steps to reproduce]:

  1. Open the latest Nightly browser with the profile from prerequisites.
  2. Navigate to "about:logins" page.
  3. Observe the "about:logins" page.

[Expected results]:

  • The screen should be different than the one when you are not logged into a FxA account.

[Actual results]:

  • The same screen is displayed as when you are not logged into a FxA account.
Flags: qe-verify+
Flags: needinfo?(rgaddis)

Agree that it would be helpful to have two, slightly different states here.

Propose changing the content header to "No synced logins found." in instances where someone is newly logged in, but with no logins. Additionally, I've dialed back the illustration opacity to 50% for an additional affordance to the change... In the future we could consider two different illustrations, but for the time being, I think it will suffice.

Betsy, is this approach ok from your perspective?

Design screenshot of the proposed solution attached.

Flags: needinfo?(rgaddis) → needinfo?(bmikel)
Attached image design.png (deleted) —
Priority: -- → P3

Yes I am OK with this. Thanks.

Flags: needinfo?(bmikel)
Whiteboard: [passwords:management] [skyline] → [passwords:management] [skyline] [strings]
Assignee: nobody → jaws
Status: NEW → ASSIGNED

FYI, we still need to account for logins import surfacing within those screens (likely in the form of a link at the base of the bulleted list)

Component: Password Manager → about:logins
Product: Toolkit → Firefox
Version: 70 Branch → unspecified
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/91d5bba42cb0 Show a different message on the login-intro if the user is signed in to Sync. r=sfoster,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191009213914) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

  • The “No synced logins found.” string is displayed on the screen when you are signed to Sync with a Firefox profile that doesn’t have any saved logins.
  • Also, the illustration opacity of the "No synced logins found." screen is lower.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: