Closed Bug 1572471 Opened 5 years ago Closed 5 years ago

Make an easy way to verify expected configurations for locales/regions with the modern configuration

Categories

(Firefox :: Search, task, P3)

task
Points:
5

Tracking

()

RESOLVED FIXED

People

(Reporter: standard8, Assigned: daleharvey)

References

Details

Once we've got the modern configuration up and running, we should make it so that there's an easy way to verify the engines on a locale/region basis without having to load individual Firefox profiles.

I'm thinking something like:

  • Reading from the RemoteSettings server (although we could read from mercurial to being with).
  • By default shows the default engines and engine order for each locale/region pair.
  • Allows to select the source of the list.
  • Allows to reduce the list down to a specific locale or region.
  • Available to show, e.g. via a tooltip.
    • Everything else available via the engine

We might be able to do this from a web server, though we might also want a privileged Firefox extension, as then we could use the configuration parser from Firefox itself.

Assignee: nobody → dharvey
Points: --- → 5

Put up a signed release @ https://github.com/mozilla/searchengine-devtools/releases

This lets you configure the region / locale and make changes to the configuration and test the results

One issue I remembered while I was typing this is I need to show what the privateDefault engine would become, I will start adding that now but otherwise would be good to know what you think Mark and what other features you would like

Flags: needinfo?(standard8)

Thanks, I think this is a good start. I think there's a couple of things that would help it:

  • A quick way to change locale or region
    • At the moment, you have to open the popup, select a different one, select reload engines.
    • Could we do something where we have something like a quick scroll? e.g. focus region and then just do up/down arrow and it shows the new engine. This would be faster to navigate between and check all the regions for a locale (or vice versa).
  • An alternative to the previous suggestion would be to view a table of the installed ids per locale and change the region (or vice versa).
  • The dark lines need to be a lighter shade - I find that quite hard to read the text.
  • I like being able to see the config and edit it. I think it would good to get it from Firefox's version, but maybe do that after remote settings is integrated?
  • I've just realised that when we get remote settings in place, that formatting is going to go out the window as it'll minimise it. Not sure what to do there.
  • For the testing side it would be nice if we could have a "apply to current profile" option (and an associated rest). Not sure if we'd need changes in FF to hack the region/locale though...
Flags: needinfo?(standard8)

A quick way to change locale or region

Yeh switched these to multi selects and reload the engines onchange now

I like being able to see the config and edit it. I think it would good to get it from Firefox's version, but maybe do that after remote settings is integrated?

Yeh lets do that after, will file

The dark lines need to be a lighter shade - I find that quite hard to read the text.

Done

I've just realised that when we get remote settings in place, that formatting is going to go out the window as it'll minimise it. Not sure what to do there.

Nope, we read this as JSON then stringify it with formatting, so formatting should persist
(https://github.com/mozilla/searchengine-devtools/blob/master/extension/content/script.js#L57)

For the testing side it would be nice if we could have a "apply to current profile" option (and an associated rest). Not sure if we'd need changes in FF to hack the region/locale though...

Yeh region is easy, locale shouldnt be too tricky I think but the settings bit is probably another post remote settings thing

Got these changes done, just waiting on them getting signed @ https://bugzilla.mozilla.org/show_bug.cgi?id=1610256

ok so updated https://github.com/mozilla/searchengine-devtools/releases

If you wanna take a look at this Mark, will close this out as done and will do the rest of the work in follow up bugs (some already filed)

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Flags: needinfo?(standard8)

Yes, definitely looking a lot better with that update. Thank you.

I've created a meta for follow-ups and also submitted a minor change.

Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.