Perfherder schema doesn't allow gcp machine names
Categories
(Taskcluster :: General, task, P1)
Tracking
(Not tracked)
People
(Reporter: dustin, Assigned: onegru)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 1 obsolete file)
[task 2019-08-08T18:29:55.647Z] 18:29:55 INFO - Validating Perfherder data against /builds/worker/workspace/mozharness/external_tools/performance-artifact-schema.json
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - Exception when reporting resource usage: Traceback (most recent call last):
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - File "/builds/worker/workspace/mozharness/mozharness/base/python.py", line 557, in _resource_record_post_run
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - self._log_resource_usage()
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - File "/builds/worker/workspace/mozharness/mozharness/base/python.py", line 692, in _log_resource_usage
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - jsonschema.validate(data, schema)
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/jsonschema/validators.py", line 478, in validate
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - cls(schema, *args, **kwargs).validate(instance)
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - File "/builds/worker/workspace/build/venv/lib/python2.7/site-packages/jsonschema/validators.py", line 123, in validate
[task 2019-08-08T18:29:55.652Z] 18:29:55 WARNING - raise error
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - ValidationError: 'taskcluster-projects/830239147953/machineTypes/n1-standard-8' is too long
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING -
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - Failed validating u'maxLength' in schema[u'properties'][u'suites'][u'items'][u'properties'][u'extraOptions'][u'items']:
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - {u'maxLength': 45, u'type': u'string'}
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING -
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - On instance[u'suites'][0][u'extraOptions'][1]:
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - 'taskcluster-projects/830239147953/machineTypes/n1-standard-8'
[task 2019-08-08T18:29:55.653Z] 18:29:55 WARNING - returning nonzero exit status 2
Reporter | ||
Comment 1•5 years ago
|
||
One of the options provided is based on the cloud instance type. In EC2, these
are pretty short, but in GCP they can be longer, and that length is required to
fully specify custom machine types, as we are likely to use in Firefox CI.
Comment 2•5 years ago
|
||
Reporter | ||
Comment 3•5 years ago
|
||
:igoldan, will you be able to commandeer these revs and make the necessary perfherder changes?
Comment 4•5 years ago
|
||
(In reply to Dustin J. Mitchell [:dustin] (he/him) from comment #3)
:igoldan, will you be able to commandeer these revs and make the necessary perfherder changes?
Sure thing.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
Actually, I'll hand this over to Octavian.
Updated•5 years ago
|
Comment 6•5 years ago
|
||
Reporter | ||
Comment 7•5 years ago
|
||
Hm, did this get forgotten? I don't think this will impact the transition on November 9, as we are not changing worker platforms at that time, so I'm going to remove the blocking annotation here.
But we are slowly creeping toward GCP, and I'd hate to see that blocked by inability to ingest tasks run in that platform.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Description
•