Open Bug 1572540 Opened 5 years ago Updated 2 years ago

GV should disable logging by default in opt GV builds

Categories

(GeckoView :: General, defect, P3)

Product:
GeckoView
Component:
General
Platform:
Unspecified
All
Type:
defect

Tracking

(Performance Impact:low, firefox69 wontfix, firefox70 fix-optional, firefox71 affected)

Project Flags:
Performance Impact low
Tracking Flags:
Tracking Status
firefox69 --- wontfix
firefox70 --- fix-optional
firefox71 --- affected

People

(Reporter: smaug, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf:pageload)

instagram on G5 through geckoview nightly from taskcluster
https://perfht.ml/2ML5Zc5

Looks like most of it is logging, and 21ms per navigation doesn't seem too bad to me anyway.

21ms is rather bad (when one of the key goals is Fenix page load performance) but not p1 bad.

Whiteboard: [qf?] → [qf:p3:pageload]

GV should enable logging by default in debug builds for the benefit of GV developers. See debugLogging API bug 1573304 to control logging.

I filed a Fenix issue asking them to call debugLogging appropriately, since GV can't know at runtime whether the app is a debug or opt build: https://github.com/mozilla-mobile/fenix/issues/4763

status-firefox70: --- → affected
Depends on: 1573304
Priority: -- → P2
Summary: MaybeHandleLoadDelegate slows down page loads → GV should disable logging by default in opt GV builds

Fenix just landed code to disable GV logging in their release builds, but we should still fix GV's default for the benefit of other GV-powered apps like FxR.

https://github.com/mozilla-mobile/fenix/commit/eb26d951ab525e510c386ef8d15068dc5fa04e0f

Blocks: 1570752
Rank: 28
Rank: 28 → 2
Priority: P2 → P3
Performance Impact: --- → P3
Keywords: perf:pageload
Whiteboard: [qf:p3:pageload]
Severity: normal → S3
Rank: 2 → 333
You need to log in before you can comment on or make changes to this bug.