Closed Bug 1572651 Opened 5 years ago Closed 5 years ago

(obsolete) Make the BoxModelHighlighter compatible with Fission

Categories

(DevTools :: Inspector, task, P1)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(Fission Milestone:M4, firefox71 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 71
Project Flags:
Fission Milestone M4
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: pbro, Assigned: rcaliman)

References

(Blocks 2 open bugs)

Details

(Whiteboard: dt-fission-m1)

Attachments

(3 files, 1 obsolete file)

Bug 1572651 - (Part 1) Add highlighter renderer base class
(deleted), text/x-phabricator-request
Details
Bug 1572651 - (Part 2) Split BoxModelHighlighter into observer and renderer parts.
(deleted), text/x-phabricator-request
Details
Bug 1572651 - (Part 3) Add option for highlighters to get node position without scroll offsets.
(deleted), text/x-phabricator-request
Details
No description provided.
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Priority: P2 → P1

Bug 1492582 will make the main browser window use an <html> root node, which will allow our normal highlighters to work in that window. As discussed though, you may still consider anchoring this in a frame inside of the .browserStack node so that the window is automatically sized to the content.

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1492582
Attachment #9091296 - Attachment is obsolete: true
Blocks: 1586251
Blocks: 1586316

To use the new box model highlighter, flip this pref to true: devtools.inspector.use-new-box-model-highlighter

Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ef33867cacb (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins https://hg.mozilla.org/integration/autoland/rev/fb5863ee4d37 (Part 2) Split BoxModelHighlighter into observer and renderer parts. r=pbro,jdescottes https://hg.mozilla.org/integration/autoland/rev/71db1896c459 (Part 3) Add option for highlighters to get node position without scroll offsets. r=pbro

Backed out 3 changesets (Bug 1572651) for devtools failure at devtools/client/inspector/test/browser_inspector_highlighter-by-type.js.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=71db1896c4593707d9965954bfaaf370e0349bd9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270694589&repo=autoland&lineNumber=2417

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=270694589&searchStr=dt&revision=b3f7b74caec224d8afd0886eb7f95c9ba164e9df

[task 2019-10-10T15:10:33.695Z] 15:10:33     INFO - TEST-INFO | screentopng: exit 0
[task 2019-10-10T15:10:33.697Z] 15:10:33     INFO - Buffered messages logged at 15:10:31
[task 2019-10-10T15:10:33.698Z] 15:10:33     INFO - Entering test bound 
[task 2019-10-10T15:10:33.699Z] 15:10:33     INFO - Adding a new tab with URL: data:text/html;charset=utf-8,custom highlighters
[task 2019-10-10T15:10:33.699Z] 15:10:33     INFO - Tab added and finished loading
[task 2019-10-10T15:10:33.699Z] 15:10:33     INFO - Opening the inspector
[task 2019-10-10T15:10:33.699Z] 15:10:33     INFO - Opening the toolbox
[task 2019-10-10T15:10:33.699Z] 15:10:33     INFO - Buffered messages logged at 15:10:32
[task 2019-10-10T15:10:33.700Z] 15:10:33     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-10T15:10:33.700Z] 15:10:33     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-10T15:10:33.700Z] 15:10:33     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-10T15:10:33.701Z] 15:10:33     INFO - Console message: [JavaScript Error: "Content Security Policy: The page’s settings blocked the loading of a resource at inline (“default-src”)." {file: "chrome://global/content/elements/panel.js" line: 62}]
[task 2019-10-10T15:10:33.701Z] 15:10:33     INFO - Buffered messages logged at 15:10:33
[task 2019-10-10T15:10:33.702Z] 15:10:33     INFO - Toolbox opened and focused
[task 2019-10-10T15:10:33.703Z] 15:10:33     INFO - Check that the inspector always sends back the same main highlighter
[task 2019-10-10T15:10:33.704Z] 15:10:33     INFO - Buffered messages finished
[task 2019-10-10T15:10:33.706Z] 15:10:33     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_highlighter-by-type.js | Uncaught exception - at resource://devtools/shared/protocol/types.js:115 - Error: undefined passed where a value is required
[task 2019-10-10T15:10:33.706Z] 15:10:33     INFO - Stack trace:
[task 2019-10-10T15:10:33.706Z] 15:10:33     INFO - identityWrite@resource://devtools/shared/protocol/types.js:115:11
[task 2019-10-10T15:10:33.706Z] 15:10:33     INFO - write@resource://devtools/shared/protocol/Request.js:113:22
[task 2019-10-10T15:10:33.706Z] 15:10:33     INFO - write@resource://devtools/shared/protocol/Request.js:39:26
[task 2019-10-10T15:10:33.707Z] 15:10:33     INFO - generateRequestMethods/</frontProto[name]@resource://devtools/shared/protocol/Front/FrontClassWithSpec.js:38:31
[task 2019-10-10T15:10:33.707Z] 15:10:33     INFO - onlyOneInstanceOfMainHighlighter@chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-by-type.js:24:35
[task 2019-10-10T15:10:33.707Z] 15:10:33     INFO - @chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_highlighter-by-type.js:15:9
[task 2019-10-10T15:10:33.708Z] 15:10:33     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1345:34
[task 2019-10-10T15:10:33.708Z] 15:10:33     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1380:11
[task 2019-10-10T15:10:33.708Z] 15:10:33     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1208:14
[task 2019-10-10T15:10:33.709Z] 15:10:33     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67
[task 2019-10-10T15:10:33.710Z] 15:10:33     INFO - Leaving test bound 
[task 2019-10-10T15:10:34.141Z] 15:10:34     INFO - Removing tab.
[task 2019-10-10T15:10:34.141Z] 15:10:34     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2019-10-10T15:10:34.177Z] 15:10:34     INFO - Got event: 'TabClose' on [object XULElement].
[task 2019-10-10T15:10:34.213Z] 15:10:34     INFO - Tab removed and finished closing
[task 2019-10-10T15:10:34.249Z] 15:10:34     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_highlighter-by-type.js | The main process DebuggerServer has no pending connection when the test ends - 
[task 2019-10-10T15:10:34.265Z] 15:10:34     INFO - GECKO(1885) | MEMORY STAT | vsize 20975570MB | residentFast 1523MB
Flags: needinfo?(rcaliman)
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b1d22c68b66d (Part 1) Add highlighter renderer base class r=jdescottes,pbro,bgrins https://hg.mozilla.org/integration/autoland/rev/e00f7651b670 (Part 2) Split BoxModelHighlighter into observer and renderer parts. r=pbro,jdescottes https://hg.mozilla.org/integration/autoland/rev/4720725e96e9 (Part 3) Add option for highlighters to get node position without scroll offsets. r=pbro

Fixed the cause for the failing test (new protocol.js argument needs to be optional because the feature works conditionally according to the pref) and submitted to autoland.

Flags: needinfo?(rcaliman)

https://hg.mozilla.org/mozilla-central/rev/b1d22c68b66d
https://hg.mozilla.org/mozilla-central/rev/e00f7651b670
https://hg.mozilla.org/mozilla-central/rev/4720725e96e9

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Blocks: 1592978
Blocks: 1593645

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → M4
Whiteboard: dt-fission → dt-fission dt-fission-m1

The patches for this bug were removed by Bug 1607755 because the setupInParent() approach that was used will no longer be maintained with Fission.

The feature will be re-implemented with an alternative approach based on JSWindowActors in Bug 1598307.

Summary: Make the BoxModelHighlighter compatible with Fission → (obsolete) Make the BoxModelHighlighter compatible with Fission
No longer blocks: 1592978, 1598307
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: