Closed Bug 1572679 Opened 5 years ago Closed 3 years ago

The Show/Hide Password button is not displayed inside the Password field.

Categories

(Firefox :: about:logins, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- wontfix

People

(Reporter: srosu, Assigned: janvi01)

References

Details

Attachments

(2 files, 2 obsolete files)

Attached image Show_Hide_button.png (deleted) —

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-08) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Steps to reproduce]:

  1. Open the browser and navigate to the "about:logins" page.
  2. Click on the “Create New Login” button.
  3. Observe the Show/Hide Password button.

[Expected result]:

  • The Show/Hide Password button is displayed inside the Password field when typing a character.

[Actual result]:

  • The Show/Hide Password button is displayed outside of the Password field.

[Notes]:

  • The Show/Hide button from the about:logins page should be displayed inside the Password field on the “Create New Login” and “Edit” mode, as shown in https://mozilla.invisionapp.com/share/EJRHBMEDKF8#/screens/372931541
  • On the “Create New Login” mode, the Show/Hide Password button is clickable when the field is empty.
  • Attached a screenshot with the issue.
Priority: -- → P3
Blocks: 1567197
Component: Password Manager → about:logins
Product: Toolkit → Firefox

Mass removing [skyline] and [passwords:management] from about:logins bugs which are no longer useful.

Whiteboard: [passwords:management] [skyline]
Attached file fireefox eye missing.jpg (obsolete) (deleted) —

This is the display when I tried to log in through add-ons. The password reveal option does not reveal itself unless I start typing., or does not reveal itself at all.

The content of attachment 9160835 [details] has been deleted for the following reason: Deleted at the request of the uploader.
Attached image fireefox reveal password missing.jpg (obsolete) (deleted) —
Attachment #9160840 - Attachment is obsolete: true

Hey, I would like to work on this.

Flags: needinfo?(sgalich)

The Show/hide button should be displayed inside the field and should only be visible when we start typing for password.

Assignee: nobody → janvibajo1
Status: NEW → ASSIGNED

This bug is not relevant anymore in light of Bug 1750072 and associated bugs.
There is a new, built-in reveal button coming to <input type=password> and we are planning to remove custom reveal implementation.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Flags: needinfo?(sgalich)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: