Disable the GFX sanity window because for some users it never closes
Categories
(Remote Protocol :: Marionette, defect, P3)
Tracking
(firefox84 fixed)
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: whimboo, Assigned: jya)
References
()
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
text/x-phabricator-request
|
Details |
As discussed in bug 1420864 we want to disable the GFX sanity window of Firefox, which comes up for some users during startup, but never closes. As such Marionette doesn't initialize, and tests fail.
To cause the window even not to appear it should be enough to set the preference sanity-test.running to true.
|
Reporter | |
Updated•5 years ago
|
|
|
Reporter | |
Comment 1•5 years ago
|
||
|
|
Reporter | |
Comment 2•5 years ago
|
||
Depends on D41357
|
|
Reporter | |
Comment 3•5 years ago
|
||
|
|
Reporter | |
Comment 4•5 years ago
|
||
I had to push another try build given that a unit test was failing on Windows where the gfx sanity window is active, and resets the newly added pref. Means that we have to skip testing this particular pref in the test.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c557764149e9c0b44077ef1c92ae0c4d8e52112c
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2b3e775a99cb
https://hg.mozilla.org/mozilla-central/rev/0c1fa26f2f67
|
|
Reporter | |
Comment 7•5 years ago
|
||
As it looks like this patch seem to have caused a start-up performance regression as covered on bug 1574837.
Sheriffs, can you please backout?
|
||
Updated•5 years ago
|
|
||
Comment 8•5 years ago
|
||
Backed out 2 changesets (bug 1572687) for causing bug 1574837.
Backout link: https://hg.mozilla.org/integration/autoland/rev/b27981be6a66f4d9d9fa1e15faaf5a7c545789bd
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 9•5 years ago
|
||
As proposed on bug 1574837, and agreed by Matt, the preference to be added to the GFX code can be sanity-test.disabled. It will be false by default.
|
||
Comment 10•5 years ago
|
||
The priority flag is not set for this bug.
:automatedtester, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•5 years ago
|
|
|
||
Comment 11•5 years ago
|
||
Backout merged: https://hg.mozilla.org/mozilla-central/rev/b27981be6a66
|
|
Reporter | |
Comment 12•5 years ago
|
||
I'm currently not working on this bug.
|
|
Reporter | |
Comment 13•4 years ago
|
||
A fix for Marionette cannot block a geckodriver release.
|
Assignee | |
Comment 14•4 years ago
|
||
We're going to disable the sanity test on marionette run
|
|
Assignee | |
Comment 15•4 years ago
|
||
We know that this test will never fail with any of the hardware used by our test infrastructure. It also force create a RDD process even when not actually used in the tests; skewing the results.
|
||
Comment 16•4 years ago
|
||
|
||
Comment 17•4 years ago
|
||
| bugherder | ||
|
||
Comment 19•4 years ago
|
||
== Change summary for alert #27433 (as of Thu, 29 Oct 2020 15:31:44 GMT) ==
Improvements:
| Ratio | Suite | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|---|
| 5% | Resident Memory | windows7-32-shippable | 557,932,953.15 -> 528,647,413.93 | ||
| 5% | Resident Memory | windows7-32-shippable | 557,663,929.65 -> 529,165,053.43 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=27433
|
|
Reporter | |
Comment 20•4 years ago
|
||
Note, these performance improvements can be seen because awsy tests are using Marionette.
|
||
Updated•2 years ago
|
Description
•