Closed
Bug 1572696
Opened 5 years ago
Closed 5 years ago
The "Search" bar elements are wrongly displayed on the left side on RTL build
Categories
(Firefox :: about:logins, defect, P2)
Tracking
()
VERIFIED
FIXED
Firefox 70
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox-esr68 | --- | unaffected |
firefox68 | --- | unaffected |
firefox69 | --- | disabled |
firefox70 | --- | verified |
People
(Reporter: cmuntean, Assigned: ntim)
References
(Regression)
Details
(Keywords: regression, rtl, Whiteboard: [passwords:management] [skyline])
Attachments
(2 files)
[Affected Versions]:
- Nightly 70.0a1
[Affected Platforms]
- All Windows
- All Mac
- All Linux
[Prerequisites]
- Have the latest Nightly RTL build installed or extracted.
- Have a Firefox profile with multiple saved logins.
[Steps to reproduce]:
- Open the latest Nightly RTL build with the profile from prerequisites.
- Navigate to "about:logins" page.
- Observe the "Search" bar and start typing.
[Expected results]:
- The magnifying glass is displayed in the right part and the text starts from the right to the left.
[Actual results]:
- The magnifying glass is displayed in the left part and the text starts from the left to right.
[Notes]:
- Also, the "Search Logins" place-holder is displayed in the left part of the "Search" bar.
- Attached a screen recording with the issue.
Comment 1•5 years ago
|
||
This behaviour was implemented in bug 1567543 based on Ehsan's suggestion. It uses dir=auto
so the rtl. vs. ltr. decision depends on the characters typed. When I test with RTL characters I see the magnifying glass move to the right side along with the text.
Ehsan, do you see a problem with the current behaviour?
Flags: needinfo?(ehsan)
Regressed by: 1567543
Updated•5 years ago
|
Keywords: regression
Comment 2•5 years ago
|
||
I think the behaviour of the text box after the user types is probably desirable, but I do a couple of other issues:
- I'm not sure if the change in the text alignment together with the change in the directionality is really desired here. I think it's probably better to left-align the text (and the icon) in LTR builds and right-align them in RTL builds.
- The initial alignment of the textbox is wrong, it appears left-aligned whereas in RTL UI the user would expect it to appear right-aligned. (This is probably language dependant as far as the placeholder text goes, but not the icon.)
Flags: needinfo?(ehsan)
Assignee | ||
Comment 3•5 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/17a2b5b4d436
Make about:logins searchbar more RTL friendly. r=Ehsan,MattN
Updated•5 years ago
|
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Comment 5•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Reporter | ||
Comment 6•5 years ago
|
||
I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-20) (64-bit) on Windows 7x64, MacOS 10.14 and Ubuntu 16.04.
- The "Search" bar elements are correctly displayed on RTL builds.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
Version: 70 Branch → unspecified
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•