Remove MediaStreamGraph strong-refs
Categories
(Core :: Audio/Video: MediaStreamGraph, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: pehrsons, Assigned: pehrsons)
References
Details
Attachments
(4 files)
MediaStreamGraphImpl is ref-counted because it has to be, but its lifetime is supposed to be controlled by the MediaStreams it contains.
Yet we have seen an increasing number of RefPtr<MediaStreamGraphImpl>, because a graph can be hard to get hold of.
This leads to problems, typically streams being added to a graph while it's in the process of shutting down - problems that are more visible after bug 1493613 as graphs now have a more limited lifetime.
This bug aims to remove most, if not all, RefPtr<MediaStreamGraphImpl>, so the graph can be referenced as intended.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Removing all strong-refs was not really viable. The ones in GraphDriver, and MediaStreamGraphImpl::DeviceChanged, are staying.
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D43664
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D43665
|
|
Assignee | |
Comment 4•5 years ago
|
||
To accomodate this, MediaStreamTrackListener::NotifyEnded/Removed get an
additional aGraph argument. NotifyEnabledStateChanged is getting it too, for
completion.
Depends on D43666
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D43667
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f61dd73cac3a
https://hg.mozilla.org/mozilla-central/rev/85ef72ebde43
https://hg.mozilla.org/mozilla-central/rev/c9807cc45067
https://hg.mozilla.org/mozilla-central/rev/08faaf9d4ef7
|
||
Comment 9•5 years ago
|
||
| bugherder uplift | ||
|
|
Assignee | |
Updated•5 years ago
|
Description
•