if you try to type a character for which you need the AltGr key (as the @ in German) nothing happenes in Mozilla/BeOS. Build-ID: 2002071310

Paul, you are most competent person in key event processing in BeOS Mozilla. Maybe we should exclude 0x5f from nsKeycodesBeOS[] (as NS_VK_ALT) ?

Well, first, I don't have a foreign character keyboard to test this with. Second, if you exclude 0x5f, you will no longer be able to use the right Alt key, which is bad. If you have a AltGr key on you keyboard, define KB_DEBUG at the top of nsWindow.cpp, and recompile. Is there a bekeycode listed in the debug output (terminal) when you press the AltGr key? If so, what is it? We may need to do something "special" here to make this work, though, I will have problems doing that without being able to test it.

-> Keyboard Navigation

OK, got german keyboard working - "@²³µ$" - by separating mIsLeftAltDown and mIsRightAltDown. Now thinking how to put AltGr to work as Alt in case if there are no corresponding special letters. But it seems non-trivial, because frequently there isnt any tag to determine what happens - e.g. German keymap generates on AltGr both ascii (1-byte) and non-ascii (2-bytes)

Paul, i investigated now about ten non-english keymaps in BeOS and have to say that we shouldnt use RightAlt as menu or accelerator key. In other case your troubles with CLOSEWINDOW event will look as childish problem in comparison. But if we decide to exclude AltGr - it needs only replacing B_COMMAND_KEY in code with B_LEFT_COMMAND key. And i changed severity to major - this is real pain for ALL non-english users. If you and supervisers/drivers agree with this proposal - i can submit patch immediately.

what key code does the AltGr generate? It has been a couple of years since I've had my hands on a non-us keyboard, but, I think it was a separate key from the right-alt key (i could be wrong, though). Making the right-alt key the key for generating foreign characters does not seem correct. I only have the Japanese keymap installed (comes with r5), and to enter foreign characters, you tap the alt key twice, which, works in mozilla (just tried it). If I get a chance, I will try installing other keymaps this week, and test those as well, but at this point, at least with my us-keyboard, I don't see a problem. So again, it comes to the first question.

Paul, problem is that generating additional chars for western keymaps is standard way in BeOS. Point. Even US-international do so. So we have logically unsolvable problem. We have arbitrary unpredicrable for each case set of keys which may be used by users to type even simplest characters, like { and } in STANDARD BeOS german keymap - and we have set of Mozilla shortcuts which also may be changed. Definitely priority should be set on user typinng, nobody wish to get something like quitting, when typing '@' in e-mail address (e.g. in same german keymap @==AltGr+q - and Q is very temptative to associate any action with it in some mozilla module). But if we set priority to user typing, it renders in general AltGr unusable as menu or shortcut key - because, as i said, BeOS keymaps conform with BeOS possible actions, not by any external. So, if you still wish to use AltGr as special Mozilla key, we should do one of those actions 1)Create different Mozilla versions for each keymap or 2)force users to redo keymaps they use or 3) force users to use Ctrl instead Alt (right control do not interfere with anything - at first look.

Allows AltGr/RightAlt use for character typing in keymaps which use RightAlt for that purpose - but disables usage of RightAlt as command key Mozilla in those keymaps. At same time, saves RightAlt functionality as command key in Mozilla for those keymaps which don't use RightAlt as "option" (BeOS term) key

Sergei, it seems as if your "QuitRequested" patch has been included in the patch you just posted. Marking NEW

removed CLOSEWINDOW patch lines, changed if(B_LEFT to if(!B_RIGHT

> "So, if you still wish to use AltGr as special Mozilla key [..]" this is no problem, as it's quite normal (at least for Germans) that AltGr and Alt have compleatly different meanings. Under no OS you can use AltGr to open menus or for the fishcam.

iirc this problem occurs on all platforms and no one has bothered to just plain fix it everywhere.

Actually, this works fine on OS/2 and Windows. The browser shouldn't even be involved in this. It should ignore Alt Grave and just let the OS give us the character with the codepoint.

Yes, timeless, my patch does it, but maybe in more intelligent way. It excludes AltGr, but only if it is used by keymap as "character entering key". Are you able to test it already - or still no BeOS in your bootloader?

Agreed. I was looking through the other ports, and only saw mention of an AltGr key under GTK and OS/2. Gtk seems to handle it, though, I'm not a Gtk dev, so I'm not sure. OS/2 seems to treat it as the right-alt key.

OS/2 only treats it as Alt with a mouse action. Normally we just ignore it.

Comment on attachment 91310 [details] [diff] [review] Patch sr=blizzard for ports code

Comment on attachment 91310 [details] [diff] [review] Patch a=asa (on behalf of drivers) for checkin to 1.1

checked in

bad news - that didn't help :(

KaiL - there qre two versions of German keymap in BeOS. I don't know which one guys put in so called "5.04"/DevEdition. One uses AltGr - another RightCtrl for your beloved chars:)

Confirmed. Another patch was uncounted for this problem - mIsMetaDown also uses B_OPTION_KEY which seems very wrong. Preparing patch

Additional patch. For Meta key. Excludes RightMeta/"Windows" key. LeftMeta still works. Sorry Paul, i see no other way to save BeZilla usability for non-english users.

Comment on attachment 93635 [details] [diff] [review] Additional patch sr=blizzard ports change

this time it helped.

Could Kai or someone else please verify with the latest build to see if it is still reproducible? since we don't have BeOS here.

Rui Xu: I already said fixed - verify my own resolving? ;)

Mark bug as verified, please reopen if disagree.