Closed Bug 1573481 Opened 5 years ago Closed 5 years ago

The login created after entering the password manager is displayed in the "Login List" only after a page refresh

Categories

(Firefox :: about:logins, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: srosu, Assigned: jaws)

References

Details

(Whiteboard: [passwords:management] [passwords:master-password])

Attachments

(2 files)

Attached video NewLogin_MasterPassword.mp4 (deleted) —

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-12) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Prerequisites]:

  • Have a Firefox profile with multiple saved logins.
  • Have a Master Password created.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites and navigate to “about:logins” page.
  2. Click the “Cancel” button from the “Password Required” pop-up.
  3. Click on the “Create New Login” button.
  4. Fill in all fields and click on the “Save” button.
  5. Enter your master password and click on the “OK” button from the pop-up.
  6. Observe the “Login List”.

[Expected result]:

  • The saved logins are displayed and the newly created login is added to the “Login List”.

[Actual result]:

  • The saved logins are displayed and the newly created login is not added to the “Login List” only after page refresh.

[Additional notes]:

  • Attached a screen recording with the issue.

I think we could darken/disable the entire page until the user enters their Master Password. I think this is an edge case as users would enter it first before adding and the failure case isn't dataloss so I'm calling this P3.

Priority: -- → P3
Whiteboard: [passwords:management] [skyline] → [passwords:management] [passwords:master-password]
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bfd9654bb461 Disable the about:logins page if Master Password is requested on load and the user cancels the dialog. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on the latest Nightly 71.0a1 (Build ID: 20191010214019) on Windows 10 x64, Mac 10.14, Ubuntu 16 x64.

  • The entire page is disabled when the “Please enter your master password.” pop-up is dismissed.
Status: RESOLVED → VERIFIED

Does this need a Beta uplift request before Monday's RC build?

Flags: needinfo?(jaws)

no, we're going to hold this for 71.

Flags: needinfo?(jaws)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: