Enable WS Monitor in all channels
Categories
(DevTools :: Netmonitor, task, P1)
Tracking
(firefox71 fixed, firefox72 fixed)
People
(Reporter: Honza, Assigned: Honza)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Let's enable WS monitor in all channels as soon as all M1 bugs are fixed.
Honza
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Here is the corresponding piece of code:
Honza
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Let's make sure this gets documented once implemented.
Sebastian
Assignee | ||
Comment 3•5 years ago
|
||
@Heng Yeow, can you please look at this, thanks!
Honza
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
QA Manual Testing Summary green:
https://testrail.stage.mozaws.net/index.php?/reports/view/2089
All deps in QA meta (bug 1584184) solved
Plan: land in 72 (Nightly) and uplift to Beta 71.
Honza
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
bugherder |
Assignee | ||
Comment 8•5 years ago
|
||
Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels
Beta/Release Uplift Approval Request
- User impact if declined: Developers not having support for inspecting WebSockets by default.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): The feature went through Nightly testing period, it's been available in DevEdition for some time and it also went through QA.
- String changes made/needed:
Comment 9•5 years ago
|
||
I am not seeing any card about enabling this feature in 71 in our Firefox Trello and we are nearing the end of the beta cycle, I would like Tania to shime in for QA before taking an uplift to beta.
Comment 10•5 years ago
|
||
Hi Pascal,
In trello I see following cards:
https://trello.com/c/hXb8yJWG/3618-network-websocket-monitor-gsoc
https://trello.com/c/cuqtUk84/805-network-websocket-monitor-gsoc
These two seem to be related with PI: https://jira.mozilla.com/browse/PI-289 from Fx71.
But, as I see the trello cards are for Fx 70.
Jan, can you take a look at the mentioned trello cards and see if they are related with PI-289?
Also, please note that testing for Preliminary Pre-Release for Websocket Inspector feature is in progress.
Assignee | ||
Comment 11•5 years ago
|
||
Harald, which one should we use?
Honza
Comment 12•5 years ago
|
||
The cards are in different boards and updated to reflect version. I wasn’t aware that we need to have enabled cards for when features stay on DE for a release; I will clarify with Thomas on how we can track that better next time.
Comment 13•5 years ago
|
||
Comment on attachment 9107462 [details]
Bug 1573805 - Enable WS Monitor in all channels
Feature got a green preliminary sign off in beta 71 by QA, uplift approved for 71 beta 11, thanks.
Comment 14•5 years ago
|
||
bugherder uplift |
Comment 15•5 years ago
|
||
I've now documented this feature on MDN; see https://github.com/mdn/sprints/issues/2276#issuecomment-559523271 for the full details. Thanks to :Honza for the amazing hacks post, which I borrowed heavily from ;-)
Let me know if you'd like any more details added to the MDN page. Thanks!
Description
•