Closed Bug 1574456 Opened 5 years ago Closed 5 years ago

Network query params with symbol + , urlEncoded %2B, are missing

Categories

(DevTools :: Netmonitor, defect, P3)

Product:
DevTools
Component:
Netmonitor
Version:
64 Branch
Type:
defect

Tracking

(firefox76 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: Fenricage, Assigned: basavaraj.bugzilla)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug)

Attachments

(2 files, 2 obsolete files)

Снимок экрана 2019-08-16 в 14.52.08.png
(deleted), image/png
Details
Bug 1574456 - Modified query string parser function to display plus symbol as + instead of space. r=honza
(deleted), text/x-phabricator-request
Details

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/76.0.3809.100 Safari/537.36

Steps to reproduce:

I Just send request, one of params is comma-separated string, its has +, and its doesnt displaying in tenwork tab in Mozilla. I check last versions of developer edition, nightly, and default browser.

Also i checked browser my friend, he has 60 version, os is debian. Its work there

Actual results:

Symbol plus, didnt dispay in network tab -> params -> my query string

i send "+namespace:value", but network tab show me "namespace:value" without +

Expected results:

i should see all my query string, i suspect that it because network tab doesnt parse urlencoded symbols, like %CA, and replace it on spaces

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Netmonitor
Product: Firefox → DevTools

its correct

Flags: needinfo?(Fenricage)

Thanks for the report!
I can reproduce the problem.

Honza

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
Priority: -- → P3

Some instructions for anyone who's interested in fixing this bug:

  1. Parsed query string is rendered in the Params side panel
    This line is interesting, it parses the query string:
    https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/devtools/client/netmonitor/src/components/ParamsPanel.js#146

That line returns namespace:value

  1. parseQueryString is implemented here:
    https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/devtools/client/netmonitor/src/utils/request-utils.js#324

Could the problem be in this function?

Could we take some inspiration from this parseQueryString implementation?
https://searchfox.org/mozilla-central/rev/f43ae7e1c43a4a940b658381157a6ea6c5a185c1/browser/extensions/pdfjs/content/web/viewer.js#2614

Honza

Flags: needinfo?(Fenricage)
Attached file Bug 1574456 - parseQueryString: Escape query string (obsolete) (deleted) —

r=honza

Hi, can I take up this issue?

Assigned to you, thanks for the help!

Honza

Assignee: nobody → basavaraj.bugzilla
Status: NEW → ASSIGNED

Hello Honza, the bug has been fixed. As advised by you, I have kept the code similar to the other parseQueryString function and only made small modifications. Kindly review the code. Thanks.

Pushed by jodvarko@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/818c4f0fe7d5 Modified query string parser function to display plus symbol as + instead of space. r=Honza,bomsy
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/048bcce2918f Modified query string parser function to display plus symbol as + instead of space: eslint-fix. CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/818c4f0fe7d5
https://hg.mozilla.org/mozilla-central/rev/048bcce2918f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Summary: Network tab, Params, if my query params has symbol + , in urlEncoded %2B, its missing, disappeared. Sry for my english → Network query params with symbol + , urlEncoded %2B, are missing
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: