Closed Bug 1574940 Opened 5 years ago Closed 5 years ago

The “x” button from the Mobile Promotion cannot be focus when navigating with the “Tab” key

Categories

(Firefox :: about:logins, defect, P1)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified

People

(Reporter: srosu, Assigned: jaws)

References

Details

(Keywords: access, Whiteboard: [passwords:management] [skyline])

Attachments

(2 files)

Attached video MobilePromotion_navigation.mp4 (deleted) —

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Prerequisites]:

  • The Firefox browser is opened.
  • You are signed with a valid FxA.
  • Have at least one saved login.

[Steps to reproduce]:

  1. Navigate to “about:logins” page.
  2. Press the "Tab" key until the "GET IT ON Google Play" button is focused.
  3. Press the “Tab” key and observe the behavior.

[Expected result]:

  • The “X’ button of the Mobile Promotion is focused.

[Actual result]:

  • The “Logins & Passwords” tab is focused.

[Notes]:

  • Attached a screen recording with the issue.
Keywords: access
Priority: -- → P1

This should be a <button>.

Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42f98e7648bd The close button in the mobile footer of about:logins should be clickable via 'Enter'. r=MattN
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-23)(64-bit) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

  • The “x” button from the Mobile Promotion can be focus using the “Tab” key. Also, if the "Enter" key is pressed while the "X" button is focused, the Mobile Promo is correctly dismissed.
Status: RESOLVED → VERIFIED
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: