Closed Bug 1575059 Opened 5 years ago Closed 5 years ago

Fix usage of nsIDocShellTreeItem in nsDocShell::RemoveFromSessionHistory and nsDocShell::InitSessionHistory

Categories

(Core :: DOM: Navigation, enhancement, P2)

Product:
Core
Component:
DOM: Navigation
Type:
enhancement

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1467221

People

(Reporter: djvj, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [rm-docshell-tree-item:session-history])

https://searchfox.org/mozilla-central/source/docshell/base/nsDocShell.cpp#3543

This method retrieves the root tree item (of same type) and erases it from the session history. Retrieving the session history object from the root docshell is no longer always possible - as the root may be out of process, or an out-of-process intermediate docshell in the ancestor list may confound the root lookup.

This is more of a watch bug than a fix bug - the work on SessionHistory for fission is ongoing, and we can close this blindly if it's fixed independently - or alter this implementation to use the new post-fission session history.

Component: DOM: Core & HTML → Document Navigation
Summary: Fix usage of nsIDocShellTreeItem in nsDocShell::RemoveFromSessionHistory → Fix usage of nsIDocShellTreeItem in nsDocShell::RemoveFromSessionHistory and nsDocShell::InitSessionHistory
Fission Milestone: --- → M5
Priority: -- → P2
Whiteboard: [rm-docshell-tree-item:session-history]
Fission Milestone: M5 → Future

Kannan says replacing nsIDocShellTreeItem calls should block enabling Fission in Nightly (M6).

Fission Milestone: Future → M6

Auditing whether this use of nsIDocShellTreeItem breaks when Fission is enabled blocks Fission Nightly.

Fission Milestone: M6 → M6b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

Clearing Fission Milestone for bugs resolved as duplicates. We don't need to track duplicates.

Fission Milestone: M6b → ---
You need to log in before you can comment on or make changes to this bug.