Closed Bug 1575096 Opened 5 years ago Closed 5 years ago

Disable beforeunload/unload event breakpoints until they work on the main window

Categories

(DevTools :: Debugger, task, P1)

Product:
DevTools
Component:
Debugger
Type:
task

Tracking

(firefox69 fixed, firefox70 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox69 --- fixed
firefox70 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [debugger-reserve])

Attachments

(1 file)

Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
Details

Since https://bugzilla.mozilla.org/show_bug.cgi?id=1569775 is an issue, we should remove these events from the available event breakpoint list for now.

Blocks: dbg-event-bps, dbg-70
Priority: -- → P1
Attachment #9086546 - Attachment description: Bug 1569775 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast → Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast
Whiteboard: [debugger-reserve]
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a0b2d7e9e932 Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast

https://hg.mozilla.org/mozilla-central/rev/a0b2d7e9e932

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70

Comment on attachment 9086546 [details]
Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast

Beta/Release Uplift Approval Request

  • User impact if declined:
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is essentially removing 2 checkboxes from the debugger UI and should have no other effect.
  • String changes made/needed:
Attachment #9086546 - Flags: approval-mozilla-beta?

Comment on attachment 9086546 [details]
Bug 1575096 - Disable beforeunload/unload event-breakpoint UI until fixed. r=jlast

Disables buggy functionality that isn't ready to ship yet. Approved for 69.0b16.

Attachment #9086546 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: