Closed
Bug 157554
Opened 22 years ago
Closed 12 years ago
Failure to instantiate plugin in nsPluginStreamListenerPeer::OnStartRequest does not cause us to layout alternate renderings
Categories
(Core Graveyard :: Plug-ins, defect, P2)
Core Graveyard
Plug-ins
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla17
People
(Reporter: peterlubczynski-bugs, Assigned: johns)
References
Details
(Whiteboard: [PL2:P2])
Sometimes plugin code needs to open the stream of an OBJECT (or EMBED) tag in
order to find out the mime-type to use. We do not handle failure here gracefully.
For example:
<object data="missing.file" width=100 height=100>
Alternate Rendering
</object>
This fails becuase layout never gets a call to CantRenderReplaceElement in
OnStartRequest.
Another similar case that fails is when we are only able to determine the
mime-type from the HTTP header and it's not a handled by a plugin, we never give
layout a chance to see if it can handle it.
For example:
<object data="http://www.mozilla.org/ width=100 height=100></object>
This fails because a new child nsFrameFrame or nsImageFrame are not created in
OnStartRequest.
I'm investigating on ways to fix this. Calling back into layout for replacement
probably isn't a problem. However, we need to ensure we do not make two requests
when trafering control to the IFRAME or IMG tag code.
|
Reporter | |
Comment 1•22 years ago
|
||
Since this is sort of serious and I have sort of an idea of how to fix it now,
lets try to get this done in the near-term....of course if plugins move to
content in bug 90268, this bug would be a good learning experience :)
Priority: -- → P2
Whiteboard: [PL2:NA]
Target Milestone: --- → mozilla1.2beta
|
||
Updated•22 years ago
|
Severity: major → normal
Target Milestone: mozilla1.2beta → mozilla1.0.2
|
|
Reporter | |
Comment 2•22 years ago
|
||
*** Bug 156199 has been marked as a duplicate of this bug. ***
|
|
Reporter | |
Comment 3•22 years ago
|
||
*** Bug 157150 has been marked as a duplicate of this bug. ***
|
|
||
Updated•22 years ago
|
Whiteboard: [PL2:NA] → [PL2:P2]
Target Milestone: mozilla1.0.2 → mozilla1.2alpha
|
|
Reporter | |
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → mozilla1.3alpha
|
|
Reporter | |
Comment 5•22 years ago
|
||
*** Bug 175465 has been marked as a duplicate of this bug. ***
|
||
Updated•15 years ago
|
QA Contact: shrir → plugins
|
Assignee | |
Comment 6•13 years ago
|
||
bug 745030 should either fix this or make it a much simpler fix
Assignee: peterl-bugs → jschoenick
Status: NEW → ASSIGNED
Depends on: 745030
Target Milestone: mozilla1.3beta → ---
|
|
Assignee | |
Comment 7•12 years ago
|
||
This was fully fixed by 745030, although most cases of it had been fixed previously.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → INCOMPLETE
Target Milestone: --- → mozilla17
|
|
Assignee | |
Updated•12 years ago
|
Resolution: INCOMPLETE → FIXED
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•