Closed Bug 1575682 Opened 5 years ago Closed 5 years ago

De-duplicate profiler pop-up code

Categories

(Core :: Gecko Profiler, task, P2)

Product:
Core
Component:
Gecko Profiler
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1575682 - Add a mechanism for the popup to signal that its size has changed
(deleted), text/x-phabricator-request
Details
Bug 1575682 - Bridge the perf actor so that it can be reused with the popup
(deleted), text/x-phabricator-request
Details
Bug 1575682 - Change the behavior of the popup shortcuts to stop the profiler on capture
(deleted), text/x-phabricator-request
Details
Bug 1575682 - De-duplicate the profiler popup code
(deleted), text/x-phabricator-request
Details
Bug 1575682 - Rename the recording buttons, and add a cancel button
(deleted), text/x-phabricator-request
Details
Bug 1575682 - Stop the profiler popup from "blipping" with unrendered content
(deleted), text/x-phabricator-request
Details

We have two different copies of the profiler popup code UI from the Gecko profiler add-on. We should de-duplicate the UI.

Blocks: 1566920
Priority: -- → P2

This change is a one-liner, but I wanted to call it out in its own commit
since it is a true behavior change.

Depends on D43117

This changeset is the bulk of the changes. It should contain most of
the minimum necessary changes to have everything working correctly.

Depends on D43118

Depends on D43119

Julien, I believe I've addressed all your comments on this.

Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/31a67b9d47ab Bridge the perf actor so that it can be reused with the popup r=julienw https://hg.mozilla.org/integration/autoland/rev/985902e9abdb Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw https://hg.mozilla.org/integration/autoland/rev/e4a75438c032 De-duplicate the profiler popup code r=julienw https://hg.mozilla.org/integration/autoland/rev/abee6fadcd4d Rename the recording buttons, and add a cancel button r=julienw https://hg.mozilla.org/integration/autoland/rev/c44c69605b87 Add a mechanism for the popup to signal that its size has changed r=julienw https://hg.mozilla.org/integration/autoland/rev/7e60a2013e96 Stop the profiler popup from "blipping" with unrendered content r=julienw
Backout by aiakab@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c7a9d59c5bd1 Backed out 6 changesets for causing devtools failures on browser_all_files_referenced.js CLOSED TREE

Oof, I totally didn't fix the error in my try run before landing.

Flags: needinfo?(gtatum)
Pushed by gtatum@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/405920f43feb Bridge the perf actor so that it can be reused with the popup r=julienw https://hg.mozilla.org/integration/autoland/rev/26400b2f0421 Change the behavior of the popup shortcuts to stop the profiler on capture r=julienw https://hg.mozilla.org/integration/autoland/rev/597f7761880e De-duplicate the profiler popup code r=julienw https://hg.mozilla.org/integration/autoland/rev/a18707f036e0 Rename the recording buttons, and add a cancel button r=julienw https://hg.mozilla.org/integration/autoland/rev/05e51bac8c99 Add a mechanism for the popup to signal that its size has changed r=julienw https://hg.mozilla.org/integration/autoland/rev/d69418f996f7 Stop the profiler popup from "blipping" with unrendered content r=julienw
Assignee: nobody → gtatum
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: