Surface enable/disable actions in Themes Manager
Categories
(Toolkit :: Add-ons Manager, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: amyt, Assigned: mstriemer)
References
(Depends on 1 open bug)
Details
Attachments
(7 files)
dark-theme.svg
The enable/disable actions are currently in the meatball menu of the themes list view. We would like to surface them one level higher so users can enable and disable themes without having to click into the meatball menu.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Updated•5 years ago
|
|
Reporter | |
Comment 1•5 years ago
|
||
Per 9/26/19 meeting:
- Change "Enabled" section header to "Your Active Theme"
- Change "Disabled" section header to "Other Installed Themes"
- Add "Disable" button to the current theme
- Add "Enable" button to themes listed under "Your Themes"
- Meatball menu options should be "Remove" and "Manage"
- Add theme skeleton to the 3 default themes
Emanuela to attach sketches, Jeff to review proposed copy changes above.
|
|
Reporter | |
Updated•5 years ago
|
|
|
||
Comment 2•5 years ago
|
||
Can we consider "Your Themes" instead of "Your Theme Collection"? The term "collection" can be confused with the AMO feature.
|
||
Comment 4•5 years ago
|
||
For Disabled Themes, can we do "Installed Themes"
|
|
Reporter | |
Comment 5•5 years ago
|
||
How about "Your Active Theme" for the current theme, and "Other Installed Themes" for the disabled themes?
|
||
Comment 8•5 years ago
|
||
Skeleton light theme
|
|
||
Comment 9•5 years ago
|
||
Skeleton default theme
|
|
||
Comment 10•5 years ago
|
||
Reference mock.
Not included in the mock but included in the actual page is the section Recommended Themes below Other Installed Themes.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 11•5 years ago
|
||
|
|
Assignee | |
Comment 12•5 years ago
|
||
|
||
Comment 13•5 years ago
|
||
|
|
||
Comment 14•5 years ago
|
||
|
||
Comment 15•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/58af480a23ba
https://hg.mozilla.org/mozilla-central/rev/2283d57d384b
|
||
Comment 16•5 years ago
|
||
Hello,
Verified the fix on the latest Nightly (72.0a1/20191126212708) under Windows 10 Pro 64-bit and MacOS Catalina 10.15.
Going over several variants of the layout of the Themes Manager which were proposed throughout the comments in this ticket and the state of the Themes Manager on the latest Nightly, the following were observed:
- in what regards the buttons to enable/disable themes present on the themes cards, these have been detailed in Comment 10 of https://bugzilla.mozilla.org/show_bug.cgi?id=1570792
- the headers proposed for the Enabled and Disabled themes are not present. The old ones are still used.
- built-in themes have previews now
Please see the attached screenshot for further details.
Can you please confirm that these are intended changes before changing the status of the bug? Thank you!
|
|
Assignee | |
Comment 17•5 years ago
|
||
That's correct. I filed bug 1599813 since the headings should've been updated, but I forgot about it.
|
|
||
Comment 18•5 years ago
|
||
Hello,
I will verify this fix after the dependency (https://bugzilla.mozilla.org/show_bug.cgi?id=1599813) has been fixed and validated.
|
|
Assignee | |
Updated•5 years ago
|
Description
•