Closed
Bug 1575999
Opened 5 years ago
Closed 4 years ago
Android javadoc lint isn't sufficiently strict
Categories
(GeckoView :: General, enhancement, P3)
Tracking
(firefox70 wontfix, firefox79 fixed)
RESOLVED
FIXED
mozilla79
People
(Reporter: nalexander, Assigned: agi)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Locally, I observe:
2:07.37 public void setWebNotificationDelegate(final @Nullable WebNotificationDelegate delegate) {
2:07.37 ^
2:07.58 1 warning
How did that sneak past the new Javadoc lint? The answer is that it’s an “up-to-date” thing. The way that Gradle works, it doesn’t actually re-run the Javadoc task, so the warning doesn’t show up if it's shown up in a previous task (build, say). That's what's happening, I think, in the A(lints)
job where this landed: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2d59ce318c46327d78c46c00086ea847223c383c&selectedJob=262768326.
To address this, I reckon that we need to do one of the following, in rough descending order of preference:
- Ensure that the JSON output file is a task output, and ensure that it's not in the objdir before we run the lint, so that the task must run to create it
- Split the Gradle tasks in some way so that Javadoc always runs
- Force the Javadoc task to always run (and accept slower local builds)
Updated•5 years ago
|
Blocks: internal-gv-ergonomics
Type: defect → enhancement
status-firefox70:
--- → affected
Priority: -- → P2
Updated•5 years ago
|
Rank: 40
Updated•5 years ago
|
Rank: 40 → 19
Priority: P2 → P3
Assignee | ||
Comment 1•4 years ago
|
||
Updated•4 years ago
|
Assignee: nobody → agi
Status: NEW → ASSIGNED
Pushed by asferro@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f5a98fe7608
Always run javadoc tasks during lint. r=nalexander,esawin
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox79:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla79
Updated•4 years ago
|
Updated•3 years ago
|
Has Regression Range: --- → yes
Updated•3 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•