Closed Bug 1576072 Opened 5 years ago Closed 5 years ago

Don't use a blue dot for indicating granted permissions in the identity block

Categories

(Firefox :: Site Identity, enhancement, P1)

Product:
Firefox
Component:
Site Identity
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: nchevobbe, Assigned: johannh)

References

Details

(Whiteboard: [privacy-panel][skyline])

Attachments

(4 files)

Screenshot at Aug 23 08-30-12.png
(deleted), image/png
Details
Bug 1576072 - Add a new icon for granted permissions in the identity block + panel. r=nhnt11
(deleted), text/x-phabricator-request
Details
Bug 1576072 - Backed out changeset 0a7463d82e5f. r=timhuang
(deleted), text/x-phabricator-request
Details
Bug 1576072 - Backed out changeset 93ae831e2fb9. r=timhuang
(deleted), text/x-phabricator-request
Details
Attached image Screenshot at Aug 23 08-30-12.png (deleted) —

See the screenshot to have more context about this.

I think the permission indicator is a new addition, and it confused me at first: I though it was one of the "tab content updated" indicator that was misplaced. At the moment it makes me think the dot doesn't belong to the same icon as the "lock" one.

Maybe this could be adjusted:

  • the color could be more different than the existing one
  • the permission dot could be placed not so close to the tab strip? Maybe it could be in the bottom right corner, overlapping with the lock icon
Assignee: nobody → jhofmann
Blocks: protections-panel
Status: NEW → ASSIGNED
Component: Device Permissions → Site Identity and Permission Panels
Priority: -- → P1
Whiteboard: [privacy-panel][skyline]

I talked to Bryan and based on all the feedback we got we agree that the blue dot might not be the best indicator for this. We're going to show an icon instead.

Summary: New Permission indicator (blue dot) looks a lot like the "content updated" indicator (cyan dot) → Don't use a blue dot for indicating granted permissions in the identity block
Depends on: 1566810
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8761f39863af Backed out changeset 0a7463d82e5f. r=timhuang https://hg.mozilla.org/integration/autoland/rev/6b7bd6cb5ce0 Backed out changeset 93ae831e2fb9. r=timhuang https://hg.mozilla.org/integration/autoland/rev/4c2f7afa73da Add a new icon for granted permissions in the identity block + panel. r=nhnt11

https://hg.mozilla.org/mozilla-central/rev/8761f39863af
https://hg.mozilla.org/mozilla-central/rev/4c2f7afa73da

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Depends on: 1577731

Hi,
I believe that at some point there was an intension to reduce the number of icons in URL bar
Here are few traces of this.
https://mozilla.invisionapp.com/share/38S2U6FPFKD#/screens/359913354
Adding an separate icon for the permissions just brings back the original number of icons.
Technically it is the same I-icon that was removed earlier but with a new image

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: